Skip to content

Conversation

@jmorrell-cloudflare
Copy link
Contributor

@jmorrell-cloudflare jmorrell-cloudflare commented Oct 23, 2025

Reworks how we're generating and annotating cache spans

Removes cache_control.expiration, cache_control.cacheability in favor of using the Cache-Control header value directly

New attributes:

cache_match

cache.request.ignore_method
cache.request.url
cache.request.method
cache.request.header.range
cache.request.header.if_modified_since
cache.request.header.if_none_match
cache.response.status_code
cache.response.body.size
cache.response.cache_status
cache.response.success

cache_put

cache.request.url
cache.request.method
cache.request.payload.status_code
cache.request.payload.header.cache_control
cache.request.payload.header.cache_tag
cache.request.payload.header.etag
cache.request.payload.header.expires
cache.request.payload.header.last_modified
cache.request.payload.size
cache.response.success

cache_delete

cache.request.ignore_method
cache.request.url
cache.response.status_code
cache.response.success

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 23, 2025

CodSpeed Performance Report

Merging #5399 will not alter performance

Comparing jmorrell/cache-instrumentation (042f8d8) with main (0a9873d)

Summary

✅ 33 untouched
⏩ 9 skipped1

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant