Skip to content

Conversation

@mar-cf
Copy link
Contributor

@mar-cf mar-cf commented Dec 30, 2025

Set tracing event info before marking request as delivered, removing some duplicated code and requiring custom events to implement get event info (duplicate of #5798, so this will likely be removed).

@github-actions
Copy link

github-actions bot commented Dec 30, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@mar-cf mar-cf force-pushed the mar/alarm-event-order branch from 69a7941 to c9597b3 Compare December 30, 2025 18:35
@mar-cf mar-cf marked this pull request as ready for review December 31, 2025 11:31
@mar-cf mar-cf requested review from a team as code owners December 31, 2025 11:31
@mar-cf mar-cf requested a review from fhanau December 31, 2025 11:31
Copy link
Contributor

@fhanau fhanau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I'm still convinced that moving the delivered() calls backwards is unlikely to do anything since we covered the case of JsRpc but it won't be harmful either and conceivably reduces the risk of breakage if that changes in the future.

@mar-cf mar-cf force-pushed the mar/alarm-event-order branch from c9597b3 to 7d269c2 Compare January 5, 2026 11:26
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 5, 2026

CodSpeed Performance Report

Merging #5800 will improve performance by 12.6%

Comparing mar/alarm-event-order (7d269c2) with main (e46f4d8)

Summary

⚡ 1 improvement
✅ 139 untouched
⏩ 38 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
Encode_ASCII_256[TextEncoder][0/0/256] 3.5 ms 3.1 ms +12.6%

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mar-cf mar-cf merged commit 3dc8195 into main Jan 5, 2026
31 of 34 checks passed
@mar-cf mar-cf deleted the mar/alarm-event-order branch January 5, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants