Skip to content

Conversation

@fhanau
Copy link
Contributor

@fhanau fhanau commented Jan 5, 2026

This allows us to eliminate many, many crates.
For serde_json, explicitly add a feature we need that previously was added implicitly.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@fhanau fhanau force-pushed the felix/010525-update-swc branch from 6be1d6c to 9774986 Compare January 5, 2026 17:18
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 5, 2026

CodSpeed Performance Report

Merging #5828 will improve performance by 8.24%

Comparing felix/010525-update-swc (d9d8e64) with main (4ccae53)

Summary

⚡ 1 improvement
✅ 128 untouched
⏩ 49 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
New_Tiny_Value 5.1 ms 4.7 ms +8.24%

Footnotes

  1. 49 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@fhanau fhanau marked this pull request as ready for review January 5, 2026 18:07
@fhanau fhanau requested review from a team as code owners January 5, 2026 18:07
@fhanau
Copy link
Contributor Author

fhanau commented Jan 5, 2026

@mikea since you originally added the transpiler code: Could this break transpiling in subtle ways that are not apparent here? Updating the crates and using swc_common directly looks like it is free lunch, is there any more testing I should do?

@fhanau fhanau requested a review from mikea January 5, 2026 18:11
@fhanau fhanau force-pushed the felix/010525-update-swc branch from 9774986 to 355008e Compare January 5, 2026 21:33
This allows us to eliminate many, many crates.
For serde_json, explicitly add a feature we need that previously was added
implicitly.
@fhanau fhanau force-pushed the felix/010525-update-swc branch from 355008e to d9d8e64 Compare January 6, 2026 17:05
@fhanau fhanau merged commit 613091c into main Jan 6, 2026
32 of 34 checks passed
@fhanau fhanau deleted the felix/010525-update-swc branch January 6, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants