Skip to content

Conversation

whoiskatrin
Copy link
Contributor

@whoiskatrin whoiskatrin commented Aug 7, 2025

uses shared request parsing with parameter-based routing: parseTokenEndpointRequest() handles client authentication and body parsing once, then routes to either handleRevocationRequest() or handleTokenRequest() based on request parameters

claude code was using in this PR

Copy link

changeset-bot bot commented Aug 7, 2025

🦋 Changeset detected

Latest commit: 6de93dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-oauth-provider Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@threepointone
Copy link
Collaborator

@kentonv does this look ok to you?

Copy link
Member

@kentonv kentonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this written by hand or with AI? No problem using AI obviously, but if so the commits / PR description should say so, and ideally include the prompts.

@whoiskatrin
Copy link
Contributor Author

Was this written by hand or with AI? No problem using AI obviously, but if so the commits / PR description should say so, and ideally include the prompts.

used detailed solution in #49 as the base for my implementation and fleshed out the full RFC 7009 requirements with Claude Code, wasn't really familiar with that

@kentonv
Copy link
Member

kentonv commented Aug 11, 2025

Please update the PR description to say that Claude Code was used.

(Meanwhile I just switched the repo settings to require squash+merge with PR title+description as the final commit title+description...)

@whoiskatrin whoiskatrin requested a review from kentonv August 12, 2025 09:51
@threepointone threepointone merged commit 239e753 into main Aug 13, 2025
1 check passed
@threepointone threepointone deleted the fix-revoke-token branch August 13, 2025 13:44
@threepointone threepointone mentioned this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants