fix(templates): remove invalid pinned version in generated wrangler.toml build command #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Templates currently generate: command = "cargo install -q worker-build@^0.7 && worker-build --release" Modern versions of Cargo reject the incomplete version specifier `@0.7`, causing: error: invalid value '[email protected]' ... unexpected end of input while parsing minor version number Change to unpinned install to use the latest compatible worker-build: command = "cargo install -q worker-build && worker-build --release" This resolves Cargo syntax errors on fresh Windows (and other) projects without affecting existing functionality.
Sabourifar
changed the title
Collaborator
|
I believe it is only So perhaps you were hitting a case of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates currently generate:
command = "cargo install -q worker-build@^0.7 && worker-build --release"
Modern versions of Cargo reject the incomplete version specifier
@0.7, causing: error: invalid value '[email protected]' ... unexpected end of input while parsing minor version numberChange to unpinned install to use the latest compatible worker-build: command = "cargo install -q worker-build && worker-build --release"
This resolves Cargo syntax errors on fresh Windows (and other) projects without affecting existing functionality.