Skip to content

Commit bab1724

Browse files
authored
chore: fix release build with missing env (#8950)
1 parent 191ebc1 commit bab1724

File tree

3 files changed

+18
-15
lines changed

3 files changed

+18
-15
lines changed

.changeset/cold-pumas-shout.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"create-cloudflare": patch
3+
"wrangler": patch
4+
---
5+
6+
fix: include telemetry-related environment variables in release builds

.github/workflows/changesets.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,13 @@ jobs:
3434
env:
3535
CI_OS: ${{ runner.os }}
3636
SOURCEMAPS: "false"
37+
ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}
38+
ALGOLIA_PUBLIC_KEY: ${{ secrets.ALGOLIA_PUBLIC_KEY }}
39+
SENTRY_DSN: "https://[email protected]/583"
40+
NODE_ENV: "production"
41+
# This is the "production" key for sparrow analytics.
42+
# Include this here because this step will rebuild Wrangler and needs to have this available
43+
SPARROW_SOURCE_KEY: "50598e014ed44c739ec8074fdc16057c"
3744

3845
- name: Create Version PR or Publish to NPM
3946
id: changesets
@@ -44,14 +51,6 @@ jobs:
4451
env:
4552
GITHUB_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
4653
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
47-
ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}
48-
ALGOLIA_PUBLIC_KEY: ${{ secrets.ALGOLIA_PUBLIC_KEY }}
49-
SENTRY_DSN: "https://[email protected]/583"
50-
51-
NODE_ENV: "production"
52-
# This is the "production" key for sparrow analytics.
53-
# Include this here because this step will rebuild Wrangler and needs to have this available
54-
SPARROW_SOURCE_KEY: "50598e014ed44c739ec8074fdc16057c"
5554

5655
- name: Deploy non-NPM Packages
5756
id: deploy

.github/workflows/prereleases.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,11 @@ jobs:
4242
env:
4343
NODE_ENV: "production"
4444
CI_OS: ${{ runner.os }}
45+
# this is the "test/staging" key for sparrow analytics
46+
SPARROW_SOURCE_KEY: "5adf183f94b3436ba78d67f506965998"
47+
ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}
48+
SENTRY_DSN: "https://[email protected]/583"
49+
ALGOLIA_PUBLIC_KEY: ${{ secrets.ALGOLIA_PUBLIC_KEY }}
4550

4651
- name: Check for errors
4752
run: pnpm run check
@@ -52,11 +57,6 @@ jobs:
5257
run: pnpm --filter wrangler publish --tag beta
5358
env:
5459
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
55-
# this is the "test/staging" key for sparrow analytics
56-
SPARROW_SOURCE_KEY: "5adf183f94b3436ba78d67f506965998"
57-
ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}
58-
SENTRY_DSN: "https://[email protected]/583"
59-
ALGOLIA_PUBLIC_KEY: ${{ secrets.ALGOLIA_PUBLIC_KEY }}
6060

6161
- name: Publish miniflare@beta to NPM
6262
run: pnpm --filter miniflare publish --tag beta
@@ -67,8 +67,6 @@ jobs:
6767
run: pnpm --filter create-cloudflare publish --tag beta
6868
env:
6969
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
70-
# this is the "test/staging" key for sparrow analytics
71-
SPARROW_SOURCE_KEY: "5adf183f94b3436ba78d67f506965998"
7270

7371
- name: Publish workers-shared@beta to NPM
7472
run: pnpm --filter workers-shared publish --tag beta

0 commit comments

Comments
 (0)