fix specified environments being ignored for remote bindings in some cases #10130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
added
the
skip-v3-pr
🦋 Changeset detectedLatest commit: 1d7c840 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
dario-piotrowicz
force-pushed
the
dario/DEVX-2141/maybeStartRemoteSession-ignoring-env-fix
branch
from
77007b1 to
cb072d0
Compare
dario-piotrowicz
force-pushed
the
dario/DEVX-2141/maybeStartRemoteSession-ignoring-env-fix
branch
from
cb072d0 to
1d7c840
Compare
penalosa
approved these changes
Aug 5, 2025
dario-piotrowicz
deleted the
dario/DEVX-2141/maybeStartRemoteSession-ignoring-env-fix
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9916
Fixes https://jira.cfdata.org/browse/DEVX-2141
There are three related changes/fixes in this PR:
getPlatformProxyis currently not taking into account specified environments for remote bindingsvitest-pool-workersmaybeStartOrUpdateRemoteProxySessionfunction so that callers can specify environments (this enables the abovementioned two fixes, since bothgetPlatformProxyandvitest-pool-workersuse this function)For more details check out the changesets 🙂
experimental_maybeStartOrUpdateRemoteProxySessionparameters cloudflare-docs#24060