Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Aug 5, 2025

The modules are behind the enable_nodejs_fs_module and experimental flags.

Changes are available from worker 20250812


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: unenv relared changes are not backported

@vicb vicb requested review from a team as code owners August 5, 2025 09:51
@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2025

🦋 Changeset detected

Latest commit: 1b1d707

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@cloudflare/unenv-preset Minor
@cloudflare/vite-plugin Patch
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 5, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10224

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10224

miniflare

npm i https://pkg.pr.new/miniflare@10224

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10224

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10224

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10224

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10224

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10224

wrangler

npm i https://pkg.pr.new/wrangler@10224

commit: 1b1d707

@danlapid
Copy link
Contributor

danlapid commented Aug 5, 2025

@vicb thanks for this!!!
@vicb @jasnell let's wait on merging this until a hybrid module is not required.
We can implement all of that functionality in the runtime and James will.
We want to move away from polyfills, hybrid modules don't get us there.

cloudflare/workerd#4688

@jasnell
Copy link
Contributor

jasnell commented Aug 5, 2025

cloudflare/workerd#4688

@jasnell
Copy link
Contributor

jasnell commented Aug 12, 2025

I should be able to verify by tomorrow if we have the entire polyfilled api surface accounted for. Once I verify that we should be good. Plan is to lift the experimental flag likely by end of next week at the latest

@petebacondarwin petebacondarwin changed the base branch from main to dependabot/npm_and_yarn/workerd-and-workers-types-6f6996fced August 13, 2025 08:12
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/workerd-and-workers-types-6f6996fced branch from b457324 to a8cb1e2 Compare August 13, 2025 08:50
Base automatically changed from dependabot/npm_and_yarn/workerd-and-workers-types-6f6996fced to main August 13, 2025 10:28
@petebacondarwin petebacondarwin force-pushed the vicb/node-fs branch 2 times, most recently from e1d2f7b to 8dbc54a Compare August 15, 2025 08:55
@vicb
Copy link
Contributor Author

vicb commented Aug 25, 2025

I have updated the code in the last fixup commit, should be ready to go when tests are green

@vicb
Copy link
Contributor Author

vicb commented Aug 26, 2025

Thanks for the review @dario-piotrowicz
I have added the TODO for later when a default date is set at https://github.com/cloudflare/workerd/blob/8bc9530513d8274430a54808a6b5d6c79a18ae79/src/workerd/io/compatibility-date.capnp#L914

@dario-piotrowicz
Copy link
Member

dario-piotrowicz commented Aug 26, 2025

Thanks for the review @dario-piotrowicz I have added the TODO for later when a default date is set at https://github.com/cloudflare/workerd/blob/8bc9530513d8274430a54808a6b5d6c79a18ae79/src/workerd/io/compatibility-date.capnp#L914

ok, thanks for the extra context 🙂👍

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 26, 2025
@vicb vicb merged commit 7c339ae into main Aug 26, 2025
37 of 38 checks passed
@vicb vicb deleted the vicb/node-fs branch August 26, 2025 18:05
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 26, 2025
Copy link

@Matusy43122 Matusy43122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants