fix: prevent duplicate logging of warnings during wrangler dev server lifecycle events #10225

devin-ai-integration · 2025-08-05T10:11:51Z

This PR addresses the duplicate logging issue in wrangler dev where warnings were being displayed multiple times during server state changes (start/stop/reload) or seemingly randomly. The fix uses the existing logger.once.warn() mechanism to ensure warnings only appear once per dev session.

Changes Made

Core Fix

ConfigController.ts: Updated 6 warning calls to use logger.once.warn() instead of logger.warn():
- Queue warnings for remote mode
- Analytics Engine warnings for service-worker format
- Service binding warnings for remote mode
- Upstream protocol warnings for remote mode
- Container warnings for remote mode
- SQLite in Durable Objects warnings for remote mode
print-bindings.ts: Updated the warnOrError() function to use logger.once.warn() for binding-related warnings

Test Coverage

duplicate-logging.test.ts: Added comprehensive test suite with 5 test cases that verify warnings appear exactly once during multiple config resolutions:
- Queue warnings test
- Analytics Engine warnings test (using service-worker format detection)
- Service binding warnings test
- Container warnings test (with proper durable object configuration)
- Upstream protocol warnings test

Technical Approach

The fix leverages the existing logger.once mechanism in packages/wrangler/src/logger.ts which maintains a history of logged messages to prevent duplicates. This approach is preferable to other solutions because:

It's already implemented and tested in the codebase
It preserves the warning messages exactly as they were
It only prevents true duplicates - warnings can still appear in different dev sessions
It's consistent with how other parts of the codebase handle duplicate logging

Review Focus Areas

High Priority:

Verify that logger.once.warn() is the correct approach vs. addressing root cause of duplicate calls
Confirm test scenarios accurately represent real-world wrangler dev usage patterns
Check that warnings still appear appropriately in legitimate scenarios (just not duplicated)

Medium Priority:

Review test coverage completeness - are there other warnings that could have duplicate logging?
Validate service-worker format detection in Analytics Engine test works as expected
Ensure no memory/performance implications from logger.once history tracking

Testing Notes:

Tests use ConfigController directly rather than full wrangler dev integration
Service-worker format is triggered by using addEventListener syntax instead of ES modules
All tests verify exactly 1 warning appears during 3 consecutive config resolutions

Tests
- Tests included
Public documentation
- Documentation not necessary because: this is a bug fix that doesn't change user-facing behavior
Wrangler V3 Backport
- Not necessary because: this is a bug fix that should be evaluated for backport after main PR is merged

Link to Devin run: https://app.devin.ai/sessions/328baf572c9d40c38d5f7f5256dacaa7
Requested by: @dario-piotrowicz

devin-ai-integration · 2025-08-05T10:11:53Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

changeset-bot · 2025-08-05T10:11:55Z

🦋 Changeset detected

Latest commit: 4394bbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-08-05T10:13:55Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10225

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10225

miniflare

npm i https://pkg.pr.new/miniflare@10225

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10225

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10225

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10225

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10225

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10225

wrangler

npm i https://pkg.pr.new/wrangler@10225

commit: 4394bbd

packages/wrangler/src/__tests__/duplicate-logging.test.ts

dario-piotrowicz · 2025-08-05T10:59:39Z

packages/wrangler/src/__tests__/duplicate-logging.test.ts

+	mockAccountId();
+	mockApiToken();


do you need to mock the account id and api token?

Hey Devin, can you reply to the above question?

packages/wrangler/src/__tests__/duplicate-logging.test.ts

- Add comments explaining why controller.set() is called 3 times (to test duplicate prevention) - Add comment explaining why Analytics Engine test uses service worker format (to trigger specific warning) - Keep authentication mocks as they are required for remote mode and container tests Addresses GitHub comments from dario-piotrowicz on PR #10225 Co-Authored-By: [email protected] <[email protected]>

github-actions · 2025-08-05T11:12:53Z

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main devin/1754387590-fix-duplicate-logging-issue-6855 might be a good starting point.

Notes:

your PR branch should be named v3-backport-10225
add the skip-v3-pr label to the current PR to stop this workflow from failing

dario-piotrowicz · 2025-08-05T11:25:57Z

Devin, can you do this too? #10225 (comment)

- Add comments explaining why controller.set() is called 3 times (to test duplicate prevention) - Add comment explaining why Analytics Engine test uses service worker format (to trigger specific warning) - Keep authentication mocks as they are required for remote mode and container tests Addresses GitHub comments from dario-piotrowicz on PR #10225 Co-Authored-By: [email protected] <[email protected]>

dario-piotrowicz · 2025-08-05T13:12:41Z

packages/wrangler/src/__tests__/duplicate-logging.test.ts

+	mockAccountId();
+	mockApiToken();


Hey Devin, can you reply to the above question?

packages/wrangler/src/__tests__/duplicate-logging.test.ts

- Add comments explaining why controller.set() is called 3 times (to test duplicate prevention) - Add comment explaining why Analytics Engine test uses service worker format (to trigger specific warning) - Keep authentication mocks as they are required for remote mode and container tests Addresses GitHub comments from dario-piotrowicz on PR #10225 Co-Authored-By: [email protected] <[email protected]>

dario-piotrowicz · 2025-08-05T14:22:11Z

something went quite wrong here, there are lots of files changes and conflicts, could you undo the changes that you've made after commit df7c54d?

… lifecycle events - Updated ConfigController.ts to use logger.once.warn() for warnings that should only appear once per dev session - Updated print-bindings.ts warnOrError function to use logger.once.warn() for binding warnings - Added comprehensive tests to verify duplicate logging prevention for all warning types - Covers queue, analytics engine, service binding, container, and upstream protocol warnings - Tests verify warnings appear exactly once during multiple config resolutions Fixes #6855 Co-Authored-By: [email protected] <[email protected]>

Address GitHub comment by replacing dynamic fs imports with a proper top-level import. This follows standard Node.js patterns and improves code readability. - Replace 'const fs = await import("node:fs");' with top-level import - Use 'writeFileSync' directly instead of 'fs.writeFileSync' - Maintains same functionality while following better practices Co-Authored-By: [email protected] <[email protected]>

- Add comments explaining why controller.set() is called 3 times (to test duplicate prevention) - Add comment explaining why Analytics Engine test uses service worker format (to trigger specific warning) - Keep authentication mocks as they are required for remote mode and container tests Addresses GitHub comments from dario-piotrowicz on PR #10225 Co-Authored-By: [email protected] <[email protected]>

… function - Address GitHub comments by creating reusable helper function - Remove container warning test as functionality doesn't exist in v3 codebase - Fix TypeScript linting errors by replacing 'any' types with 'object' Co-Authored-By: [email protected] <[email protected]>

workers-devprod added this to workers-sdk Aug 5, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Aug 5, 2025

vicb reviewed Aug 5, 2025

View reviewed changes

packages/wrangler/src/__tests__/duplicate-logging.test.ts Outdated Show resolved Hide resolved

devin-ai-integration bot marked this pull request as ready for review August 5, 2025 10:58

devin-ai-integration bot requested a review from a team as a code owner August 5, 2025 10:58

dario-piotrowicz reviewed Aug 5, 2025

View reviewed changes

devin-ai-integration bot added the skip-v3-pr Skip validation of presence of a v3 backport PR label Aug 5, 2025

devin-ai-integration bot mentioned this pull request Aug 5, 2025

fix: prevent duplicate logging of warnings during wrangler dev server lifecycle events (v3 backport) #10230

Open

15 tasks

dario-piotrowicz added skip-v3-pr Skip validation of presence of a v3 backport PR and removed skip-v3-pr Skip validation of presence of a v3 backport PR labels Aug 5, 2025

dario-piotrowicz reviewed Aug 5, 2025

View reviewed changes

devin-ai-integration bot force-pushed the devin/1754387590-fix-duplicate-logging-issue-6855 branch from e46c528 to df7c54d Compare August 5, 2025 13:55

devin-ai-integration bot requested a review from a team August 5, 2025 13:55

devin-ai-integration bot requested review from a team as code owners August 5, 2025 13:55

devin-ai-integration bot and others added 4 commits August 5, 2025 14:42

devin-ai-integration bot force-pushed the devin/1754387590-fix-duplicate-logging-issue-6855 branch from df7c54d to 856d720 Compare August 5, 2025 14:47

dario-piotrowicz force-pushed the devin/1754387590-fix-duplicate-logging-issue-6855 branch from 775b610 to 856d720 Compare August 5, 2025 17:59

dario-piotrowicz added 3 commits August 5, 2025 19:05

revert unnecessary changes

011811f

improve testConfigOnceWarning function

6866dfa

add comments back

4394bbd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: prevent duplicate logging of warnings during wrangler dev server lifecycle events #10225

fix: prevent duplicate logging of warnings during wrangler dev server lifecycle events #10225

devin-ai-integration bot commented Aug 5, 2025

Uh oh!

devin-ai-integration bot commented Aug 5, 2025

Uh oh!

changeset-bot bot commented Aug 5, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Aug 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

dario-piotrowicz Aug 5, 2025

Uh oh!

dario-piotrowicz Aug 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

dario-piotrowicz commented Aug 5, 2025

Uh oh!

dario-piotrowicz Aug 5, 2025

Uh oh!

Uh oh!

dario-piotrowicz commented Aug 5, 2025

Uh oh!

Uh oh!

fix: prevent duplicate logging of warnings during wrangler dev server lifecycle events #10225

Are you sure you want to change the base?

fix: prevent duplicate logging of warnings during wrangler dev server lifecycle events #10225

Conversation

devin-ai-integration bot commented Aug 5, 2025

Changes Made

Core Fix

Test Coverage

Technical Approach

Review Focus Areas

Uh oh!

devin-ai-integration bot commented Aug 5, 2025

🤖 Devin AI Engineer

Uh oh!

changeset-bot bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dario-piotrowicz Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

dario-piotrowicz commented Aug 5, 2025

Uh oh!

dario-piotrowicz Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dario-piotrowicz commented Aug 5, 2025

Uh oh!

Uh oh!

changeset-bot bot commented Aug 5, 2025 •

edited

Loading

pkg-pr-new bot commented Aug 5, 2025 •

edited

Loading