Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/three-toys-feel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

fix: script should be accepted as a positional arg in the `versions upload` command
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe("versions --help", () => {
COMMANDS
wrangler versions view <version-id> View the details of a specific version of your Worker
wrangler versions list List the 10 most recent Versions of your Worker
wrangler versions upload Uploads your Worker code and config as a new Version
wrangler versions upload [script] Uploads your Worker code and config as a new Version
wrangler versions deploy [version-specs..] Safely roll out new Versions of your Worker by splitting traffic between multiple Versions
wrangler versions secret Generate a secret that can be referenced in a Worker

Expand Down Expand Up @@ -49,7 +49,7 @@ describe("versions subhelp", () => {
COMMANDS
wrangler versions view <version-id> View the details of a specific version of your Worker
wrangler versions list List the 10 most recent Versions of your Worker
wrangler versions upload Uploads your Worker code and config as a new Version
wrangler versions upload [script] Uploads your Worker code and config as a new Version
wrangler versions deploy [version-specs..] Safely roll out new Versions of your Worker by splitting traffic between multiple Versions
wrangler versions secret Generate a secret that can be referenced in a Worker

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,31 @@ describe("versions upload", () => {
`);
});

test("should accept script as a positional arg", async () => {
mockGetScript();
mockUploadVersion(false);

// Setup
writeWranglerConfig({
name: "test-name",
// i.e. would error if the arg wasn't picked up
main: "./nope.js",
});
writeWorkerSource();
setIsTTY(false);

const result = runWrangler("versions upload index.js");

await expect(result).resolves.toBeUndefined();

expect(std.out).toMatchInlineSnapshot(`
"Total Upload: xx KiB / gzip: xx KiB
Worker Startup Time: 500 ms
Uploaded test-name (TIMINGS)
Worker Version ID: 51e4886e-2db7-4900-8d38-fbfecfeab993"
`);
});

test("should print preview url if version has preview", async () => {
mockGetScript();
mockUploadVersion(true);
Expand Down
1 change: 1 addition & 0 deletions packages/wrangler/src/versions/upload.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export const versionsUploadCommand = createCommand({
owner: "Workers: Authoring and Testing",
status: "stable",
},
positionalArgs: ["script"],
args: {
script: {
describe: "The path to an entry point for your Worker",
Expand Down
Loading