Improve resource provisioning #10521

penalosa · 2025-09-01T16:05:21Z

Fixes DEVX-1737, DEVX-1738, DEVX-2171, and DEVX-1740

Improves the Wrangler auto-provisioning feature by:

writing back changes to the user's config file (not necessary, but can make it resilient to binding name changes)
fixing --dry-run
fixing bindings view for specific versions to not display TOML
some improvements to R2

Tests
- Tests included
- Tests not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: coming later, tracked in DEVX-2165
Wrangler V3 Backport
- Wrangler PR:
- Not necessary because: beta feature in v3

changeset-bot · 2025-09-01T16:05:25Z

🦋 Changeset detected

Latest commit: 040c1e9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-09-01T16:07:26Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10521

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10521

miniflare

npm i https://pkg.pr.new/miniflare@10521

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10521

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10521

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10521

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10521

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10521

wrangler

npm i https://pkg.pr.new/wrangler@10521

commit: 040c1e9

emily-shen · 2025-09-01T16:42:06Z

packages/wrangler/src/versions/view.ts

this is a really nice command, i had no idea it existed until now

(adding it to the docs here: cloudflare/cloudflare-docs#24833)

Honestly, me neither until writing this PR!

github-actions · 2025-09-30T12:54:00Z

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main penalosa/resource-provisioning-next might be a good starting point.

Notes:

your PR branch should be named v3-backport-10521
add the skip-v3-pr label to the current PR to stop this workflow from failing

packages/wrangler/src/__tests__/provision.test.ts

edmundhung · 2025-09-30T16:33:02Z

.changeset/rotten-glasses-smile.md

+Improves the Wrangler auto-provisioning feature by:
+- Writing back changes to the user's config file (not necessary, but can make it resilient to binding name changes)
+- Fixing --dry-run
+- Fixing bindings view for specific versions to not display TOML


Nit: Should we mention --x-provision just so people know this is behind an experimental flag and the way to test it out?

Also, it would be nice if you can add some details on what the fix for --dry-run is about.

The PR description also mentions "some improvements to R2", would be nice to details what they are

packages/wrangler/src/__tests__/provision.test.ts

petebacondarwin · 2025-10-02T16:05:53Z

packages/wrangler/src/api/startDevWorker/utils.ts

 			bindings.send_email.push({ ...binding, name: name });
 		} else if (binding.type === "wasm_module") {
+			if (!("source" in binding)) {
+				continue;


should this not be an error?

Or at least a warning to the user?

This function is a bit lossy when used with WorkerMetadataBinding (there's a warning in the comment above, but maybe that should be louder?). Essentially we can't really reconstruct legacy bindings like WASM/Text/Data from just the metadata because they also require access to the Worker's modules

vicb · 2025-10-02T18:40:14Z

packages/wrangler/src/api/startDevWorker/utils.ts

 }

+/**
+ * Convert either StartDevWorkerOptions["bindings"] or WorkerMetadataBinding[] to CfWorkerInit["bindings"]


nit: I like when comments start with a one sentence high level summary of what the function does

Is that not kinda what this line is?

vicb · 2025-10-02T18:41:31Z

packages/wrangler/src/api/startDevWorker/utils.ts

 		if (binding.type === "plain_text") {
 			bindings.vars ??= {};
-			bindings.vars[name] = binding.value;
+			bindings.vars[name] = "value" in binding ? binding.value : binding.text;


would binding.value ?? binding.text work here and below?

No, because the types don't overlap

packages/wrangler/src/deployment-bundle/bindings.ts

packages/wrangler/src/deployment-bundle/create-worker-upload-form.ts

vicb · 2025-10-02T18:50:53Z

packages/wrangler/src/kv/helpers.ts

 	} else if (previewIsDefined) {
+		if (getFlag("RESOURCES_PROVISION")) {
+			assert(binding);
+			return getIdFromSettings(config, binding, isLocal);


Suggested change

return getIdFromSettings(config, binding, isLocal);

return await getIdFromSettings(config, binding, isLocal);

we should probably have a lint check for that

Is this a problem? It's an async function so returning a promise is perfectly valid

vicb · 2025-10-02T18:51:08Z

packages/wrangler/src/kv/helpers.ts

+		!namespace.preview_id
+	) {
+		assert(binding);
+		return getIdFromSettings(config, binding, isLocal);


Suggested change

return getIdFromSettings(config, binding, isLocal);

return await getIdFromSettings(config, binding, isLocal);

vicb · 2025-10-02T18:51:38Z

packages/wrangler/src/kv/helpers.ts

 }

-export function getKVNamespaceId(
+async function getIdFromSettings(


nit: add JSDoc

petebacondarwin · 2025-10-02T16:07:48Z

packages/wrangler/src/api/startDevWorker/utils.ts

 			bindings.send_email.push({ ...binding, name: name });
 		} else if (binding.type === "wasm_module") {
+			if (!("source" in binding)) {
+				continue;


Or at least a warning to the user?

packages/wrangler/src/deployment-bundle/bindings.ts

petebacondarwin · 2025-10-03T10:03:34Z

packages/wrangler/src/deployment-bundle/bindings.ts

+	override inherit(): void {
+		if (!this.binding.bucket_name) {
+			this.binding.bucket_name = INHERIT_SYMBOL;
+		}
+	}


I am struggling to get my head around the logic here and in canInherit(). Could you add some comments about how we decide whether we can inherit an R2 binding?
Also, it might help to move this function next to canInherit() since the logic appears to be tightly coupled between the two.

packages/wrangler/src/deployment-bundle/bindings.ts

petebacondarwin · 2025-10-03T10:46:36Z

packages/wrangler/src/deployment-bundle/bindings.ts

+
+	/**
+	 * Inheriting an R2 binding replaces the id property (bucket_name for R2) with the inheritance symbol.
+	 * This works when deploying (and is appropriate for all other binding types), but it means that the


Ah! This is the motivation I was failing to understand.
Thank you!

packages/wrangler/src/api/startDevWorker/utils.ts

packages/wrangler/src/deployment-bundle/bindings.ts

.changeset/rotten-glasses-smile.md

dario-piotrowicz · 2025-10-03T16:45:58Z

packages/wrangler/src/deployment-bundle/bindings.ts

 }

-function getSettings(
+export function getSettings(


Should this function be moved to a shared location (e.g. a file in the utils dir)? 🤔 (possibly as a followup)

packages/wrangler/src/deployment-bundle/bindings.ts

Co-authored-by: Dario Piotrowicz <[email protected]>

Co-authored-by: James Opstad <[email protected]>

penalosa requested a review from a team as a code owner September 1, 2025 16:05

workers-devprod added this to workers-sdk Sep 1, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Sep 1, 2025

emily-shen reviewed Sep 1, 2025

View reviewed changes

penalosa force-pushed the penalosa/resource-provisioning-next branch from d880601 to 3845580 Compare September 2, 2025 11:56

penalosa requested a review from a team as a code owner September 2, 2025 16:02

penalosa marked this pull request as draft September 9, 2025 15:17

penalosa force-pushed the penalosa/resource-provisioning-next branch from 8ab18a0 to c4f361d Compare September 29, 2025 16:11

penalosa marked this pull request as ready for review September 30, 2025 12:47

emily-shen reviewed Sep 30, 2025

View reviewed changes

packages/wrangler/src/__tests__/provision.test.ts Outdated Show resolved Hide resolved

penalosa added the skip-v3-pr Skip validation of presence of a v3 backport PR label Sep 30, 2025

edmundhung reviewed Sep 30, 2025

View reviewed changes

petebacondarwin reviewed Oct 2, 2025

View reviewed changes

vicb reviewed Oct 2, 2025

View reviewed changes

packages/wrangler/src/deployment-bundle/bindings.ts Outdated Show resolved Hide resolved

vicb reviewed Oct 2, 2025

View reviewed changes

packages/wrangler/src/deployment-bundle/bindings.ts Outdated Show resolved Hide resolved

vicb reviewed Oct 2, 2025

View reviewed changes

packages/wrangler/src/deployment-bundle/create-worker-upload-form.ts Outdated Show resolved Hide resolved

vicb reviewed Oct 2, 2025

View reviewed changes

packages/wrangler/src/kv/helpers.ts

}

export function getKVNamespaceId(

async function getIdFromSettings(

Copy link

Contributor

vicb Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add JSDoc

petebacondarwin approved these changes Oct 3, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Oct 3, 2025

penalosa requested a review from vicb October 3, 2025 10:40

petebacondarwin reviewed Oct 3, 2025

View reviewed changes

jamesopstad reviewed Oct 3, 2025

View reviewed changes

dario-piotrowicz approved these changes Oct 3, 2025

View reviewed changes

penalosa force-pushed the penalosa/resource-provisioning-next branch 2 times, most recently from 02a064a to 7ed9ee1 Compare October 13, 2025 11:13

penalosa and others added 21 commits October 14, 2025 09:23

Implement updates to provisioning

6a148f2

add tests

34445fc

fix tests

4a8c0b9

remove logging

c37e1f5

fix KV namespace ID

901764c

fix tests

85bff0d

fix tests

873fe97

fix e2e snapshots

5d10db7

Create rotten-glasses-smile.md

5c37e9e

improve changeset

fea39cd

address comments

c71bf7d

support provisioning remote bindings

8a61e28

Update .changeset/rotten-glasses-smile.md

fc95f2d

Co-authored-by: Dario Piotrowicz <[email protected]>

Update packages/wrangler/src/deployment-bundle/bindings.ts

d02713a

Co-authored-by: Dario Piotrowicz <[email protected]>

Update .changeset/rotten-glasses-smile.md

ef19052

Co-authored-by: Dario Piotrowicz <[email protected]>

Update packages/wrangler/src/deployment-bundle/bindings.ts

fb3078b

Co-authored-by: James Opstad <[email protected]>

address comments

80c8761

fix tests & remove dev behaviour

4829081

add test for redirected config

265ccf9

fix lint

8050ca2

update header

4a4fad4

penalosa force-pushed the penalosa/resource-provisioning-next branch from 7ed9ee1 to 4a4fad4 Compare October 14, 2025 08:23

Revert various changes

040c1e9

jamesopstad approved these changes Oct 14, 2025

View reviewed changes

jamesopstad merged commit 88b5b7f into main Oct 14, 2025
36 of 37 checks passed

github-project-automation bot moved this from Approved to Done in workers-sdk Oct 14, 2025

jamesopstad deleted the penalosa/resource-provisioning-next branch October 14, 2025 10:38

workers-devprod mentioned this pull request Oct 13, 2025

Version Packages #10960

Merged

	return getIdFromSettings(config, binding, isLocal);
	return await getIdFromSettings(config, binding, isLocal);

Improve resource provisioning #10521

Improve resource provisioning #10521

Uh oh!

Conversation

penalosa commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

penalosa commented Sep 1, 2025 •

edited

Loading

changeset-bot bot commented Sep 1, 2025 •

edited

Loading

pkg-pr-new bot commented Sep 1, 2025 •

edited

Loading