Skip to content

Conversation

@edmundhung
Copy link
Member

@edmundhung edmundhung commented Sep 16, 2025

Fixes #10098.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not wrangler patch

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2025

🦋 Changeset detected

Latest commit: 942fd7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 16, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10677

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10677

miniflare

npm i https://pkg.pr.new/miniflare@10677

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10677

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10677

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10677

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10677

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10677

wrangler

npm i https://pkg.pr.new/wrangler@10677

commit: 942fd7e

@edmundhung edmundhung closed this Sep 16, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Done in workers-sdk Sep 16, 2025
@edmundhung edmundhung reopened this Sep 16, 2025
@github-project-automation github-project-automation bot moved this from Done to Untriaged in workers-sdk Sep 16, 2025
@edmundhung edmundhung marked this pull request as ready for review September 17, 2025 11:14
@edmundhung edmundhung requested review from a team as code owners September 17, 2025 11:14
@edmundhung edmundhung force-pushed the edmundhung/vite-build-time-env-var branch from b057314 to d2ab32d Compare September 19, 2025 13:43
Copy link
Contributor

@jamesopstad jamesopstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 22, 2025
@edmundhung edmundhung changed the title fix(vite-plugin-cloudflare): populate build time env var from .env fix(vite-plugin-cloudflare): populate Hyperdrive local connection strings from .env Sep 22, 2025
@edmundhung edmundhung merged commit d7aa0ae into main Sep 22, 2025
37 of 38 checks passed
@edmundhung edmundhung deleted the edmundhung/vite-build-time-env-var branch September 22, 2025 12:57
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 22, 2025
@michrome
Copy link

Hey @edmundhung is there an easy/quick way to bring this fix over to @astrojs/cloudflare?

Issue ref withastro/astro#14540 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Hyperdrive local env variable is not working with vite

3 participants