-
Notifications
You must be signed in to change notification settings - Fork 1k
Stabilise Worker Loader binding #10721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6503ea9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Add missing inspector_port and container_engine properties to DevConfig in configuration test - Remove invalid schema property from logfwdr configuration - Add missing worker_loaders property to type generation test mock - Add missing Environment properties: keep_names, assets, observability, compliance_region, images Co-Authored-By: [email protected] <[email protected]>
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
- Add missing worker_loaders property to configToDTS object - Add test case with worker loader bindings to verify type generation - Update test snapshots to include expected WorkerLoader type output Follows the same pattern as rate limit bindings for consistent implementation. Co-Authored-By: [email protected] <[email protected]>
dario-piotrowicz
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂
Merged
petebacondarwin
added a commit
that referenced
this pull request
Sep 23, 2025
This reverts commit 55a10a3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the worker loader binding from unsafe to a proper binding.
https://jira.cfdata.org/browse/CR-1306677
Previously config looked like:
and after this PR it will look like: