Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Oct 1, 2025

Adding TanStack to the list of frameworks C3 supports

Fixes https://jira.cfdata.org/browse/DEVX-2211


@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2025

🦋 Changeset detected

Latest commit: 9d3af2b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 1, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10842

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10842

miniflare

npm i https://pkg.pr.new/miniflare@10842

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10842

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10842

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10842

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10842

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10842

wrangler

npm i https://pkg.pr.new/wrangler@10842

commit: 9d3af2b

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2211/c3-tanstack-start branch from e82058f to 7eab915 Compare October 1, 2025 22:10
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2211/c3-tanstack-start branch from 7eab915 to 3ee5cd5 Compare October 1, 2025 22:59
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review October 2, 2025 08:39
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner October 2, 2025 08:39
@dario-piotrowicz dario-piotrowicz marked this pull request as draft October 2, 2025 17:11
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2211/c3-tanstack-start branch 2 times, most recently from 4c7d2e4 to 18f705b Compare October 16, 2025 11:28
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review October 16, 2025 12:54
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2211/c3-tanstack-start branch from 18f705b to 286e36d Compare October 21, 2025 16:15
Copy link
Contributor

@jamesopstad jamesopstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I've just suggested updating the naming so we always use the full framework name (we haven't been consistent about this with other frameworks but might as well start here). The PR description also needs updating.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Oct 22, 2025
@dario-piotrowicz
Copy link
Member Author

Works great!

😄

I've just suggested updating the naming so we always use the full framework name (we haven't been consistent about this with other frameworks but might as well start here).

I think we've consistently been not using the full framework name (something that I was also not super on board with) that's why, for consistency same I didn't here, I am happy to do so (also since that is my personal preference) although yeah I think this breaks or adds inconsistency with what we currently have 👍

The PR description also needs updating.

yeah, thanks 🙂

@dario-piotrowicz dario-piotrowicz requested a review from a team October 22, 2025 14:53
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner October 22, 2025 14:53
@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main dario/DEVX-2211/c3-tanstack-start might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10842
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2211/c3-tanstack-start branch from d5d9a66 to 90bd9ea Compare October 22, 2025 14:56
@petebacondarwin petebacondarwin merged commit af18b48 into main Oct 22, 2025
31 checks passed
@petebacondarwin petebacondarwin deleted the dario/DEVX-2211/c3-tanstack-start branch October 22, 2025 17:35
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants