-
Notifications
You must be signed in to change notification settings - Fork 1.1k
C3: add TanStack Start framework template #10842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9d3af2b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
e82058f to
7eab915
Compare
7eab915 to
3ee5cd5
Compare
4c7d2e4 to
18f705b
Compare
18f705b to
286e36d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! I've just suggested updating the naming so we always use the full framework name (we haven't been consistent about this with other frameworks but might as well start here). The PR description also needs updating.
😄
I think we've consistently been not using the full framework name (something that I was also not super on board with) that's why, for consistency same I didn't here, I am happy to do so (also since that is my personal preference) although yeah I think this breaks or adds inconsistency with what we currently have 👍
yeah, thanks 🙂 |
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
d5d9a66 to
90bd9ea
Compare
Adding TanStack to the list of frameworks C3 supports
Fixes https://jira.cfdata.org/browse/DEVX-2211