-
Notifications
You must be signed in to change notification settings - Fork 1k
C3: add TanStack Start framework template #10842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 18f705b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
e82058f
to
7eab915
Compare
7eab915
to
3ee5cd5
Compare
await retry( | ||
{ times: 300, sleepMs: 5000 }, | ||
async () => await fetch(`http://127.0.0.1:${port}${verifyPreview.route}`), | ||
async () => await fetch(`http://localhost:${port}${verifyPreview.route}`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this and the other url below have been updated because the Vite server does not serve by default 127.0.0.1
"--framework", | ||
"react", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not really necessary, I've added it just in case (since we haven't tested the solid tanstack implementation) 🙂
3ee5cd5
to
5a5f2d9
Compare
4c7d2e4
to
18f705b
Compare
First iteration on https://jira.cfdata.org/browse/DEVX-2211 (to be updated when the Tanstack CLI does eventually hopefully include a Cloudflare add-on)