Skip to content

Conversation

@mikenomitch
Copy link
Contributor

@mikenomitch mikenomitch commented Oct 1, 2025

Adds new Container instance types to validation

@mikenomitch mikenomitch requested review from a team as code owners October 1, 2025 22:52
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2025

🦋 Changeset detected

Latest commit: a6e0700

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 1, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10844

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10844

miniflare

npm i https://pkg.pr.new/miniflare@10844

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10844

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10844

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10844

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10844

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10844

wrangler

npm i https://pkg.pr.new/wrangler@10844

commit: a6e0700

Copy link
Contributor

@IRCody IRCody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Comment on lines +76 to +77
"dev", // legacy
"standard", // legacy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should print a warning if these are used I think so users know they will go away at some point?

Also unsure but would it make sense to change user-provided values here from lite->dev and standard -> standard-1 and just say in the warning that you are doing that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah lets do this, but can do it in a follow up. Would like to get this one out and into next release

@IRCody IRCody added the skip-v3-pr Skip validation of presence of a v3 backport PR label Oct 1, 2025
@mikenomitch mikenomitch force-pushed the mikenomitch/add-new-instance-types branch from 8522fe1 to 9bbd687 Compare October 2, 2025 06:58
@mikenomitch mikenomitch force-pushed the mikenomitch/add-new-instance-types branch from a3bd414 to 9997dda Compare October 2, 2025 07:46
@emily-shen emily-shen force-pushed the mikenomitch/add-new-instance-types branch 2 times, most recently from d74f2f3 to b06372a Compare October 2, 2025 09:04
@emily-shen emily-shen force-pushed the mikenomitch/add-new-instance-types branch from b06372a to e387b06 Compare October 2, 2025 09:05
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Oct 2, 2025
@edmundhung edmundhung merged commit 7a4d0da into main Oct 2, 2025
35 of 37 checks passed
@edmundhung edmundhung deleted the mikenomitch/add-new-instance-types branch October 2, 2025 10:08
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants