-
Notifications
You must be signed in to change notification settings - Fork 1k
Adds new instance types to allowed list #10844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a6e0700 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
IRCody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
| "dev", // legacy | ||
| "standard", // legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should print a warning if these are used I think so users know they will go away at some point?
Also unsure but would it make sense to change user-provided values here from lite->dev and standard -> standard-1 and just say in the warning that you are doing that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah lets do this, but can do it in a follow up. Would like to get this one out and into next release
8522fe1 to
9bbd687
Compare
a3bd414 to
9997dda
Compare
d74f2f3 to
b06372a
Compare
b06372a to
e387b06
Compare
Adds new Container instance types to validation