Add a check to vite-plugin that ensures that the version of Wrangler being used internally is correct #10848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f09b8cd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
edmundhung
reviewed
Oct 2, 2025
jamesopstad
reviewed
Oct 3, 2025
petebacondarwin
force-pushed
the
pbd/vite-plugin/check-wrangler-version
branch
from
2eb2f60 to
aee4e9c
Compare
jamesopstad
reviewed
Oct 3, 2025
petebacondarwin
force-pushed
the
pbd/vite-plugin/check-wrangler-version
branch
3 times, most recently
from
44c6011 to
25eb294
Compare
petebacondarwin
force-pushed
the
pbd/vite-plugin/check-wrangler-version
branch
2 times, most recently
from
6ec58f6 to
b8d8b65
Compare
This change delays confusing "missing export" failures to allow us to run a more user friendly version skew check, for when the user installs a version of Wrangler that breaks the plugin
…being used internally is correct This is necessary because some package managers will incorrectly merge peer dependencies with actual dependencies (often ignoring peer dependency constraints).
…angler being used internally is correct
…angler being used internally is correct
…angler being used internally is correct
Co-authored-by: James Opstad <[email protected]>
Co-authored-by: James Opstad <[email protected]>
petebacondarwin
force-pushed
the
pbd/vite-plugin/check-wrangler-version
branch
from
b8d8b65 to
f09b8cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because some package managers will incorrectly merge peer dependencies with actual dependencies (often ignoring peer dependency constraints).