add VITE_VERSION_TO_TEST environment variable to control what version of vite is used for the vite plugin playground tests
#10900
+621
−254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of vite is used for the vite plugin playground tests
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
dario-piotrowicz
commented
Oct 7, 2025
| import * as rolldownVite from "rolldown-vite"; | ||
| import * as defaultVite from "vite"; | ||
| import * as vite6 from "vite-6"; | ||
| import * as vite7 from "vite-7"; |
There was a problem hiding this comment.
having a separate/specific vite7 is unnecessary and I could just use defaultVite for testing vite 7, I just included this because I think that clearly separating the default vite module and the vite 7 one makes things clearer, I am happy to just reuse defaultVite if people don't like this
jamesopstad
reviewed
Oct 7, 2025
packages/vite-plugin-cloudflare/playground/vite-module-to-test.ts
Outdated
Show resolved
Hide resolved
petebacondarwin
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.cfdata.org/browse/DEVX-2232
Note
This PR introduces the variable that can be used locally to change the vite version being used for the playground tests, it is not adding this to the github workflows because currently the vite plugin doesn't seem to work well with vite 6 and rolldown-vite, once it does we should also use this variable in CI to run the playground tests against all (supported) vite versions