rename !legacyEnv to enableServiceEnvironments #10903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
emily-shen
commented
Oct 9, 2025
| expect.objectContaining({ | ||
| ...expectedConfig, | ||
| main: undefined, | ||
| legacy_env: true, |
There was a problem hiding this comment.
this change is irrelevant because we will have errored anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is nothing legacy about legacy env, which is extremely confusing. legacy env = true means that we are using regular wrangler environments. legacy env = false means that we are using deprecated service environments.
Unfortunately legacy_env is in our wrangler config schema and cli flags so i can't just rename it to something sensible, but we can translate this in our codebase to something that makes sense.
Thankfully we have a lot of tests for this, although concerningly a lot of tests also seem to default to service environments by default. But i'd prefer to minimise changes to tests in this PR.