[wrangler] feat: generate wrangler.jsonc in init --from-dash instead of wrangler.toml #10911
+245
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=80&v=4){kind=small}
….toml - Remove TOML import from init.ts (no longer needed) - Change init.ts to write wrangler.jsonc using JSON.stringify - Update all tests to expect wrangler.jsonc instead of wrangler.toml - Convert test snapshots from TOML to JSON format - Add changeset for minor version bump Fixes #8270 Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🦋 Changeset detectedLatest commit: 27df074 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
penalosa
reviewed
Oct 8, 2025
There was a problem hiding this comment.
You shouldn't be making any changes in this file
penalosa
reviewed
Oct 8, 2025
There was a problem hiding this comment.
you shouldn't be making any changes in this file
penalosa
reviewed
Oct 8, 2025
There was a problem hiding this comment.
you shouldn't be making any changes in this file
Address PR feedback from @penalosa to revert changes to test files that don't test the init --from-dash functionality: - get-entry.test.ts - index.test.ts - deployments.status.test.ts These files now reference wrangler.toml again since they test functionality unrelated to the init command's config generation. Co-Authored-By: [email protected] <[email protected]>
Update the --existing-script test expectations to check for wrangler.jsonc with JSON content instead of wrangler.toml with TOML content, since wrangler init --from-dash now generates JSON config files. Co-Authored-By: [email protected] <[email protected]>
The --existing-script flow runs wrangler init --from-dash which now generates wrangler.jsonc instead of wrangler.toml. Update the file copy logic to check for and copy wrangler.jsonc, wrangler.json, or wrangler.toml (in that preference order) to support both new and legacy workers. Co-Authored-By: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8270
Changes
wrangler init --from-dashto generatewrangler.jsonc(JSON with Comments) config files instead ofwrangler.tomlfiles. JSON format is more familiar to many developers and easier to programmatically modify.Changes Made
init.tsto writewrangler.jsoncusingJSON.stringify()instead ofwrangler.tomlusing TOML serialization@iarna/tomlimport from init.ts since it's no longer neededwrangler.jsoncinstead ofwrangler.tomlImportant Review Areas
[[routes]]in TOML vs"routes": [...]in JSON)Other areas to check:
.jsoncextension choice is consistent with existing codebase patterns (matchesdeploy/index.ts)wrangler.tomlin tests were missedLink to Devin run: https://app.devin.ai/sessions/a9b7bafcaa02463a8036b22511a1488d
Requested by: @smacleod