[wrangler] Fix self-bindings showing as not connected in dev #10915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8970.
This PR fixes self-bindings (service bindings where a worker binds to itself) incorrectly showing as
[not connected]
inwrangler dev
.The Problem:
When a worker has a service binding that references itself (same service name as the worker name), the connection status check in
print-bindings.ts
would look up the service in the dev registry to determine if it's connected. For self-bindings, this could show as disconnected during startup or in cases where the worker hasn't registered itself yet.The Solution:
service === context.name
[connected]
since a worker is inherently connected to itselfTesting:
SELF
) and with named entrypoints (NAMED
)fixtures/workers-with-assets
where theNAMED
binding now correctly shows as[connected]
Example Before/After:
Link to Devin run: https://app.devin.ai/sessions/70aa50c3e5164f23a2c0c8efecd919af
Requested by: [email protected]