Skip to content

Conversation

Caio-Nogueira
Copy link
Contributor

@Caio-Nogueira Caio-Nogueira commented Oct 8, 2025

Fixes WOR-926.

This PR migrates the workflow binding to use a wrapped binding that sits on top of the service binding. The goal is to avoid local dev errors due to engines not being disposed correctly.

Furthermore, this also mitigates the issue of Python Workflows not working correctly with default entrypoint classes. This happens because the runtime attempts to type translate the binding to a Python type - and fails because it doesn't really work properly when the JS object has RPC properties. Therefore, this is a backwards compatible way of fixing it.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: the binding should work the same way for customers. All we did was change how its methods are handled internally
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: this is not a patch on wrangler or miniflare

@Caio-Nogueira Caio-Nogueira requested review from a team as code owners October 8, 2025 09:31
Copy link

changeset-bot bot commented Oct 8, 2025

🦋 Changeset detected

Latest commit: de46599

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Oct 8, 2025
@Caio-Nogueira Caio-Nogueira force-pushed the caio/workflow-with-wrapped-binding branch from 06d541a to 9e575e4 Compare October 8, 2025 09:33
Copy link

pkg-pr-new bot commented Oct 8, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10919

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10919

miniflare

npm i https://pkg.pr.new/miniflare@10919

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10919

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10919

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10919

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10919

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10919

wrangler

npm i https://pkg.pr.new/wrangler@10919

commit: de46599

@Caio-Nogueira Caio-Nogueira force-pushed the caio/workflow-with-wrapped-binding branch 2 times, most recently from 91e4a59 to 99af763 Compare October 9, 2025 11:16
@Caio-Nogueira Caio-Nogueira changed the title Migrate from jsrpc to wrapped binding on the local workflow binding Add extension on top of workflow binding Oct 9, 2025
@Caio-Nogueira Caio-Nogueira force-pushed the caio/workflow-with-wrapped-binding branch 5 times, most recently from aeee441 to 06cad01 Compare October 9, 2025 14:21
@Caio-Nogueira Caio-Nogueira self-assigned this Oct 10, 2025
@Caio-Nogueira Caio-Nogueira force-pushed the caio/workflow-with-wrapped-binding branch 7 times, most recently from f335e1d to f6fcbf7 Compare October 13, 2025 18:40
@Caio-Nogueira Caio-Nogueira requested a review from a team as a code owner October 13, 2025 18:40
@Caio-Nogueira Caio-Nogueira force-pushed the caio/workflow-with-wrapped-binding branch 2 times, most recently from 86f463d to 19bddc3 Compare October 14, 2025 10:12
@Caio-Nogueira Caio-Nogueira force-pushed the caio/workflow-with-wrapped-binding branch from 19bddc3 to de46599 Compare October 15, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants