Fix manifest inspect failing due to wrong image ref

[emily-shen]

Various fixes to how detect if the image we have locally already exists in the remote repository. This means we don't have re-push and re-rollout container images.

I think at some point we moved where we resolve the image name and add the account id, meaning the manifest inspect command stopped using the full image ref. This meant the manifest inspect command was failing every time, meaning we always had to push the image D:

• Have now added a test that runs through the whole wrangler deploy flow and makes sure manifest inspect is called with the right values.

We were also previously comparing remote digest against the image id sha from the local image. Docker + containerd seems to produce the same sha's for image id and digest, which is a bug with docker probably, but meant that this was previously working in that setup. Instead we are now comparing the sha's from repoDigest (local) and the remote digest, which should be the same regardless of container engine. I think this is still valid?

Also stop deleting the tag after pushing, since (on some docker setups) that deletes the repoDigest, which we need the next time this image is built to check if it exists remotely.

Also adds an e2e test to verify that we don't re-push when the image hasn't changed, since this path seems really prone to regression.

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bugfix
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: containers

[changeset-bot]

🦋 Changeset detected

Latest commit: c62af92

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/manifest-change might be a good starting point.

Notes:

• your PR branch should be named v3-backport-10923
• add the skip-v3-pr label to the current PR to stop this workflow from failing

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10923

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10923

miniflare

npm i https://pkg.pr.new/miniflare@10923

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10923

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10923

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10923

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10923

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10923

wrangler

npm i https://pkg.pr.new/wrangler@10923

commit: c62af92

[petebacondarwin]

Approved pending linting checks etc