Skip to content

Conversation

@bxff
Copy link

@bxff bxff commented Jan 12, 2026

Fixes vercel/turborepo#11412.

The Cloudflare Vite Plugin's interactive shortcuts cause Miniflare ERR_DISPOSED errors during TanStack Start prerendering under Turborepo. This adds a TTY check to prevent registering shortcuts in Turbo environments, resolving the runtime crash during the Vite preview server phase.


  • Tests
    • Tests included/updated in shortcuts.spec.ts have been updated to account for the new TTY check and ensure shortcuts are registered in interactive environments.
    • Automated tests not possible
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix with minimal user impact

@bxff bxff requested a review from a team as a code owner January 12, 2026 10:49
@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2026

🦋 Changeset detected

Latest commit: 1ab03fc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edmundhung
Copy link
Member

Hi @bxff,

Thanks for the PR. If the root issue here is the tty, then I think it's better to check for that directly instead of checking for tooling specific environment variables. What do you think?

@bxff
Copy link
Author

bxff commented Jan 12, 2026

@edmundhung Yeah, checking for tty makes more sense, fixed now.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 12, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11875

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11875

miniflare

npm i https://pkg.pr.new/miniflare@11875

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11875

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11875

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11875

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11875

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11875

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11875

wrangler

npm i https://pkg.pr.new/wrangler@11875

commit: a93d3b2

@bxff
Copy link
Author

bxff commented Jan 13, 2026

@edmundhung fixed test that was failing due to TTY check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

can't turbo build tanstack start with prerender enabled

2 participants