Fix quick-edit relative path computation when the root folder name appears multiple times in a path #11878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot @WalshyDev, @petebacondarwin and @penalosa for working on digging into this with me 🫶 🙏
Fixes internal issue 55655
Previously, the logic assumed the root folder appeared exactly once in the path. When the root folder name appeared more than once, file modifications were not correctly detected.
For example, if the root folder is
my-worker, a path like/my-worker/my-worker/util.jswould incorrectly return/instead of/my-worker/util.js.- I've built the quick edit locally
- run it locally
- linked it to the local staging dashboard
- checked that now the bug we encountered when saving files is no longer present
A picture of a cute animal (not mandatory, but encouraged)