Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jan 12, 2026

Thanks a lot @WalshyDev, @petebacondarwin and @penalosa for working on digging into this with me 🫶 🙏

Fixes internal issue 55655

Previously, the logic assumed the root folder appeared exactly once in the path. When the root folder name appeared more than once, file modifications were not correctly detected.

For example, if the root folder is my-worker, a path like /my-worker/my-worker/util.js would incorrectly return / instead of /my-worker/util.js.

Before After
Screenshot 2026-01-13 at 14 57 08 Screenshot 2026-01-13 at 14 55 34

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
      - I've built the quick edit locally
      - run it locally
      - linked it to the local staging dashboard
      - checked that now the bug we encountered when saving files is no longer present
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2026

🦋 Changeset detected

Latest commit: f0f83ed

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 12, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11878

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11878

miniflare

npm i https://pkg.pr.new/miniflare@11878

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11878

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11878

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11878

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11878

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11878

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11878

wrangler

npm i https://pkg.pr.new/wrangler@11878

commit: f0f83ed

@dario-piotrowicz dario-piotrowicz force-pushed the dario/55655/fix-relative-path-handling branch from 471b3ba to 0cd3169 Compare January 12, 2026 13:08
@petebacondarwin petebacondarwin added the preview:quick-edit Trigger a quick edit preview deploy label Jan 12, 2026
@dario-piotrowicz dario-piotrowicz force-pushed the dario/55655/fix-relative-path-handling branch from 0cd3169 to 09a6e01 Compare January 13, 2026 10:05
…ly changed (without reflecting the same change to the source code logic that relies on the package name)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:quick-edit Trigger a quick edit preview deploy

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants