[vitest-pool-workers] Fix JSON require() in module fallback #11917
+68
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9822.
@cloudflare/vitest-pool-workers's module fallback service returned.jsonfiles ascommonJsModulesource. When a CommonJS dependency doesrequire("./data.json"),workerdwould try to parse the JSON as JavaScript and throwSyntaxError: Unexpected token ':'.This change:
.json.jsonas an ES module wrapper that exportsJSON.parse(...)(avoids object-literal__proto__prototype mutation)@cloudflare/vitest-pool-workersCommands run:
pnpm checkpnpm --filter @cloudflare/vitest-pool-workers run check:lintpnpm --filter @cloudflare/vitest-pool-workers run check:typepnpm exec vitest run test/json-require.test.ts(frompackages/vitest-pool-workers)Public documentation
A picture of a cute animal (not mandatory, but encouraged)
/_/
( o.o )