Open
Conversation
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
petebacondarwin
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12346
This PR handles bucket 2 out of 2 of the vite package to keep its size reasonable.
Only trivial cases are handled.
More complex cases will be handled as a follow-up and only disable the ESLint rule for now.
The code was created by OpenNext/Opus:
vite-plugin-cloudflare — Bucket 2 (Final) Summary
Scope
Bucket 2:
playground/[n-z]*+src/__tests__/— 51 files importingexpectfrom vitestThis completes the vite-plugin-cloudflare migration. All test files in the package are now covered by the
no-vitest-import-expectrule.ESLint Configuration (
eslint.config.mjs)Changes
Merged the bucket 1 pattern (
playground/[a-m]*/**/__tests__/**/*.ts) with the new bucket into a single config block:The e2e config block remains separate (it has its own
languageOptionsand standalonepluginsregistration since e2e files are excluded from the shared config).Migration Results
playground/[n-z]*spec + base-tests filesexpectfrom vitestConverted to complex, then further fixed (1 file)
playground/websockets/__tests__/websockets.spec.ts— initially marked complex due toexpectused in the module-scopeopenWebSocket()helper. Resolved by adding anexpect: ExpectStaticparameter toopenWebSocket()and passing it from each test's context. No eslint-disable needed.Verification
pnpm --filter @cloudflare/vite-plugin check:lint— passes (0 warnings)pnpm --filter @cloudflare/vite-plugin check:type— passespnpm --filter @cloudflare/vite-plugin test:ci— 10 files, 66 tests, all passingA picture of a cute animal (not mandatory, but encouraged)