Skip to content

[C3/wrangler] Fix Angular localhost SSR blocking in development mode #12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petebacondarwin merged 2 commits into from
Feb 24, 2026
Merged

[C3/wrangler] Fix Angular localhost SSR blocking in development mode #12648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09ce57b
[C3/wrangler] Fix Angular localhost SSR blocking in development mode
petebacondarwin Feb 23, 2026
56920b5
just use allowedHosts
petebacondarwin Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/fix-angular-localhost-ssr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"create-cloudflare": patch
"wrangler": patch
---

Fix Angular scaffolding to allow localhost SSR in development mode

Recent versions of Angular's `AngularAppEngine` block serving SSR on `localhost` by default. This caused `wrangler dev` / `wrangler pages dev` to fail with `URL with hostname "localhost" is not allowed.`

The fix passes `allowedHosts: ["localhost"]` to the `AngularAppEngine` constructor in `server.ts`, which is safe to do even in production since Cloudflare will already restrict which host is allowed.
9 changes: 0 additions & 9 deletions packages/create-cloudflare/e2e/tests/frameworks/test-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,6 @@ function getFrameworkTestConfig(pm: string): NamedFrameworkTestConfig[] {
},
nodeCompat: false,
flags: ["--style", "sass"],
// TODO: currently the Angular tests are failing with `URL with hostname "localhost" is not allowed.`
// we need to investigate this so that we can un-quarantine the Angular tests
quarantine: true,
},
{
name: "angular:workers",
Expand All @@ -189,9 +186,6 @@ function getFrameworkTestConfig(pm: string): NamedFrameworkTestConfig[] {
},
nodeCompat: false,
flags: ["--style", "sass"],
// TODO: currently the Angular tests are failing with `URL with hostname "localhost" is not allowed.`
// we need to investigate this so that we can un-quarantine the Angular tests
quarantine: true,
},
{
name: "gatsby:pages",
Expand Down Expand Up @@ -790,9 +784,6 @@ function getExperimentalFrameworkTestConfig(
nodeCompat: false,
flags: ["--style", "sass"],
verifyTypes: false,
// TODO: currently the Angular tests are failing with `URL with hostname "localhost" is not allowed.`
// we need to investigate this so that we can un-quarantine the Angular tests
quarantine: true,
},
{
name: "nuxt:workers",
Expand Down
6 changes: 5 additions & 1 deletion packages/create-cloudflare/templates/angular/pages/templates/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import { AngularAppEngine, createRequestHandler } from '@angular/ssr';

const angularApp = new AngularAppEngine();
const angularApp = new AngularAppEngine({
// It is safe to set allow `localhost`, so that SSR can run in local development,
// as, in production, Cloudflare will ensure that `localhost` is not the host.
allowedHosts: ['localhost'],
});

/**
* This is a request handler used by the Angular CLI (dev-server and during build).
Expand Down
6 changes: 5 additions & 1 deletion packages/create-cloudflare/templates/angular/workers/templates/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import { AngularAppEngine, createRequestHandler } from '@angular/ssr';

const angularApp = new AngularAppEngine();
const angularApp = new AngularAppEngine({
// It is safe to set allow `localhost`, so that SSR can run in local development,
// as, in production, Cloudflare will ensure that `localhost` is not the host.
allowedHosts: ['localhost'],
});

/**
* This is a request handler used by the Angular CLI (dev-server and during build).
Expand Down
6 changes: 5 additions & 1 deletion packages/wrangler/src/autoconfig/frameworks/angular.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,11 @@ async function overrideServerFile() {
dedent`
import { AngularAppEngine, createRequestHandler } from '@angular/ssr';

const angularApp = new AngularAppEngine();
const angularApp = new AngularAppEngine({
// It is safe to set allow \`localhost\`, so that SSR can run in local development,
// as, in production, Cloudflare will ensure that \`localhost\` is not the host.
allowedHosts: ['localhost'],
});

/**
* This is a request handler used by the Angular CLI (dev-server and during build).
Expand Down
Loading