fix(wrangler): handle d1 export with multiple tables#12734
fix(wrangler): handle d1 export with multiple tables#12734flostellbrink wants to merge 4 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: a3c11dc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
|
looks like it regressed here: #11393 |
ed2695e to
468599b
Compare
alsuren
left a comment
There was a problem hiding this comment.
Heh. Sorry about breaking that. Fix looks good.
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
this was clearly intended to work, and did work in earlier version, but has been broken. added a test and fixed the command args.
3b7ef77 to
5b1990f
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
NuroDev
left a comment
There was a problem hiding this comment.
Only one little suggestion, then happy to get this merged and shipped 😄
There was a problem hiding this comment.
Can we add a bit more detail to this change log. Maybe some kind of example showing how the previous setup of one --table flag still works like before, but now also supporting adding multiple --table flags to get multiple tables.
didn't find a corresponding issue. but encountered this:
this was clearly intended to work, and did work in earlier version, but has been broken.
added a test and fixed the command args.
Specify which tables to include in export