Add populateProcessEnv option to getPlatformProxy to populate process.env with text and JSON bindings#12770
Draft
dario-piotrowicz wants to merge 1 commit intomainfrom
Draft
Add populateProcessEnv option to getPlatformProxy to populate process.env with text and JSON bindings#12770dario-piotrowicz wants to merge 1 commit intomainfrom
populateProcessEnv option to getPlatformProxy to populate process.env with text and JSON bindings#12770dario-piotrowicz wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: f776790 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ All changesets look good |
cb4164e to
685a122
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
685a122 to
f7200f4
Compare
…ocess.env` with text and JSON bindings
f7200f4 to
f776790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR augments
getPlatformProxyto also populateprocess.envin the same way workerd does.Warning
I am not completely sure if this is ok as on by default, or if maybe it should be opt-in 🤔
getPlatformProxyin regards toprocess.envpopulation cloudflare-docs#28789A picture of a cute animal (not mandatory, but encouraged)