Add support for connect handler in miniflare tests#12775
Open
Conversation
|
fhanau
commented
Mar 5, 2026
packages/vite-plugin-cloudflare/src/workers/runner-worker/keys.ts
Outdated
Show resolved
Hide resolved
71b8572 to
76b05e4
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
76b05e4 to
e2dff1c
Compare
This is needed to add initial support for the connect handler in workerd (experimental-only for now).
e2dff1c to
270bd12
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to add initial support for the connect handler in workerd (experimental-only for now).
Part of EW-9330. Updates miniflare so that the connect handler is marked as reserved. This is needed for cloudflare/workerd#6059 to land, additional changes are included in #12802 which needs the workerd PR to be merged first. This PR should be sufficient for allowing the workerd PR to land: Reordering the steps in workerd CI shows that while miniflare tests are failing, vite and vitest tests are not so this one change should be sufficient to allow merging the workerd PR.