Skip to content

Add support for connect handler in miniflare tests#12775

Open
fhanau wants to merge 1 commit intomainfrom
felix/030526-connect-handler
Open

Add support for connect handler in miniflare tests#12775
fhanau wants to merge 1 commit intomainfrom
felix/030526-connect-handler

Conversation

@fhanau
Copy link

@fhanau fhanau commented Mar 5, 2026

This is needed to add initial support for the connect handler in workerd (experimental-only for now).

Part of EW-9330. Updates miniflare so that the connect handler is marked as reserved. This is needed for cloudflare/workerd#6059 to land, additional changes are included in #12802 which needs the workerd PR to be merged first. This PR should be sufficient for allowing the workerd PR to land: Reordering the steps in workerd CI shows that while miniflare tests are failing, vite and vitest tests are not so this one change should be sufficient to allow merging the workerd PR.


  • Tests
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Feature is behind experimental compat flag for now.

Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2026

⚠️ No Changeset found

Latest commit: 270bd12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 6, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12775

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12775

miniflare

npm i https://pkg.pr.new/miniflare@12775

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12775

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12775

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12775

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12775

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12775

wrangler

npm i https://pkg.pr.new/wrangler@12775

commit: a54f0a6

@fhanau fhanau force-pushed the felix/030526-connect-handler branch from 76b05e4 to e2dff1c Compare March 7, 2026 04:24
This is needed to add initial support for the connect handler in workerd
(experimental-only for now).
@fhanau fhanau force-pushed the felix/030526-connect-handler branch from e2dff1c to 270bd12 Compare March 7, 2026 14:23
@fhanau fhanau marked this pull request as ready for review March 7, 2026 20:12
@fhanau fhanau requested a review from a team as a code owner March 7, 2026 20:12
@workers-devprod
Copy link
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/src/shared/external-service.ts: [@cloudflare/wrangler]

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants