[wrangler] Fix d1 execute --json returning string "null" for SQL NULL values#12808
Open
MaxwellCalkin wants to merge 1 commit intocloudflare:mainfrom
Open
[wrangler] Fix d1 execute --json returning string "null" for SQL NULL values#12808MaxwellCalkin wants to merge 1 commit intocloudflare:mainfrom
MaxwellCalkin wants to merge 1 commit intocloudflare:mainfrom
Conversation
SQL NULL values were serialized as the string "null" instead of JSON null when using `wrangler d1 execute --json` with local execution. This violated RFC 4627. Remove the explicit null-to-string conversion so NULL values are preserved as proper JSON null. Fixes cloudflare#6378
🦋 Changeset detectedLatest commit: 480a493 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
alsuren
approved these changes
Mar 9, 2026
Contributor
alsuren
left a comment
There was a problem hiding this comment.
looks good, and aligns with what --remote does.
It's probably worth checking that this doesn't break the non-json output for select null, which I have not done.
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6378.
When using
wrangler d1 execute --jsonwith local execution, SQL NULL values were incorrectly serialized as the string"null"instead of JSONnull. This produced invalid JSON output that violated RFC 4627.The bug was in
executeLocally()inpackages/wrangler/src/d1/execute.ts, where the result mapping explicitly convertednullvalues to the string"null":This fix:
nullQueryResulttype to includenullin the value union (string | number | boolean | null)nullin--jsonoutputThe table display path (non-JSON) already handles this correctly via
String(v)which renders null as "null" for terminal display, so no change is needed there.