refactor(miniflare): use CorePaths for local explorer routes#13090
refactor(miniflare): use CorePaths for local explorer routes#13090petebacondarwin merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 98934ce The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
File: Issue: Changeset may not be required The README states that "Changes that are purely internal refactoring with no user-facing impact" do not require a changeset. The description explicitly says these were internal constants ("All internal consumers now use If they were part of the public API (i.e., exported and usable by external consumers), then the changeset is warranted — but the version type should likely be Issue: Changelog description quality The current description is written from an internal implementation perspective ("redundant aliases introduced before
Recommendation:
|
|
UnknownError: "Internal server error" |
|
@edmundhung Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
|
UnknownError: "Internal server error" |
|
The tests import Let me now assess the changeset concern. Since LGTM |
Fixes #12686 (comment).
A picture of a cute animal (not mandatory, but encouraged)