Add pipeline binding to wrangler.toml #6674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6d129c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10826428741/npm-package-wrangler-6674You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6674/npm-package-wrangler-6674Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10826428741/npm-package-wrangler-6674 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10826428741/npm-package-create-cloudflare-6674 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10826428741/npm-package-cloudflare-kv-asset-handler-6674npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10826428741/npm-package-miniflare-6674npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10826428741/npm-package-cloudflare-pages-shared-6674npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10826428741/npm-package-cloudflare-vitest-pool-workers-6674npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10826428741/npm-package-cloudflare-workers-editor-shared-6674npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10826428741/npm-package-cloudflare-workers-shared-6674Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
andyjessop
force-pushed
the
aj/pipeline_binding
branch
from
8d62720 to
d8c15b5
Compare
| } | ||
| if (!isRequiredProperty(value, "pipeline", "string")) { | ||
| diagnostics.errors.push( | ||
| `"${field}" bindings must have a "pipeline" field but got ${JSON.stringify( |
Contributor
There was a problem hiding this comment.
Suggested change
| `"${field}" bindings must have a "pipeline" field but got ${JSON.stringify( | |
| `"${field}" bindings must have a string "pipeline" field but got ${JSON.stringify( |
| // Pipeline bindings must have a binding and a pipeline. | ||
| if (!isRequiredProperty(value, "binding", "string")) { | ||
| diagnostics.errors.push( | ||
| `"${field}" bindings should have a string "binding" field but got ${JSON.stringify( |
Contributor
There was a problem hiding this comment.
Suggested change
| `"${field}" bindings should have a string "binding" field but got ${JSON.stringify( | |
| `"${field}" bindings must have a string "binding" field but got ${JSON.stringify( |
CarmenPopoviciu
approved these changes
Sep 12, 2024
12 tasks
Merged
andyjessop
added a commit
that referenced
this pull request
Sep 13, 2024
* main: Add pipeline binding to wrangler.toml (#6674) Fix Pages duplicating hash in redirects (#6680) Bradley/r2 event notification get (#6652) feat(wrangler): Add support for placement hints (#6625) fix(wrangler): Validate `routes` for Workers with assets (#6621) chore(deps): bump the workerd-and-workers-types group across 1 directory with 2 updates (#6673) chore(workers-shared): Configure GitHub Actions to deploy Asset Worker (#6542) feat: experimental workers assets can be ignored by adding a .assetsignore file (#6640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Supersedes #6641 from @oliy.
Author has addressed the following