-
Notifications
You must be signed in to change notification settings - Fork 1k
Bump path-to-regexp to 6.3.0 #6686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 896f847 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10862574925/npm-package-wrangler-6686 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6686/npm-package-wrangler-6686 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10862574925/npm-package-wrangler-6686 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10862574925/npm-package-create-cloudflare-6686 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10862574925/npm-package-cloudflare-kv-asset-handler-6686 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10862574925/npm-package-miniflare-6686 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10862574925/npm-package-cloudflare-pages-shared-6686 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10862574925/npm-package-cloudflare-vitest-pool-workers-6686 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10862574925/npm-package-cloudflare-workers-editor-shared-6686 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10862574925/npm-package-cloudflare-workers-shared-6686 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@DaniFoldi could you fill out the PR template? |
cecdd1c
to
896f847
Compare
Hey @penalosa, I've filled it out now, and also rebased on latest main (38 commits in two days, nice). I'd love a simpler PR template for changes like this, having opened a few PRs here already I still don't know if I need e2e test ci or not. |
Congratulations @DaniFoldi, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm152n4xi13810cjysg0gxq5e This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
What this PR solves / how to test
Yesterday, a backport for the fix of a redos in path-to-regexp was published.
PR of path-to-regexp fix: pillarjs/path-to-regexp#324 - the advisory database wasn't updated yet, so it might take a while before warnings go away.
Alternatively, path-to-regexp could be updated to
^8.1.0
, but there are a fair amount of changes between v6 and (v7 and) v8.Fixes #6720
Author has addressed the following