Making explicit that if a body is sent to delete event notification config rules it is sent with an array of ruleIds #6706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ac22b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10906479638/npm-package-wrangler-6706You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6706/npm-package-wrangler-6706Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10906479638/npm-package-wrangler-6706 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10906479638/npm-package-create-cloudflare-6706 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10906479638/npm-package-cloudflare-kv-asset-handler-6706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10906479638/npm-package-miniflare-6706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10906479638/npm-package-cloudflare-pages-shared-6706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10906479638/npm-package-cloudflare-vitest-pool-workers-6706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10906479638/npm-package-cloudflare-workers-editor-shared-6706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10906479638/npm-package-cloudflare-workers-shared-6706Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
jkoe-cf
force-pushed
the
jkoe/delete-event-notification-config-body
branch
4 times, most recently
from
7fe01b0 to
e8034d0
Compare
penalosa
approved these changes
Sep 17, 2024
…onfig rules it is sent with an array of ruleIds
edmundhung
force-pushed
the
jkoe/delete-event-notification-config-body
branch
from
e8034d0 to
2ac22b3
Compare
edmundhung
approved these changes
Sep 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Updating body for R2-2457
Fixes N/A
Author has addressed the following