Skip to content

cleanup unnecessary nullish coalescing operation #7658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged

cleanup unnecessary nullish coalescing operation #7658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/create-cloudflare/src/helpers/compatDate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export async function getWorkerdCompatibilityDate() {
const match = latestWorkerdVersion.match(/\d+\.(\d{4})(\d{2})(\d{2})\.\d+/);

if (match) {
const [, year, month, date] = match ?? [];
const [, year, month, date] = match;
Copy link
Member Author

@dario-piotrowicz dario-piotrowicz Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice the if (match) right above 👆, match has to be truthy here

const compatDate = `${year}-${month}-${date}`;

s.stop(`${brandColor("compatibility date")} ${dim(compatDate)}`);
Expand Down
Loading