Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jan 3, 2025

Fixes #7662

Renames the Solid and Next entries to SolidStart and Next.js respectively (for clarity and consistency)


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: these values are simply displayed and not tested AFAIK
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: these values are simply displayed and not tested AFAIK
  • Public documentation

@dario-piotrowicz dario-piotrowicz requested a review from a team January 3, 2025 21:27
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner January 3, 2025 21:27
@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: 9969824

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-wrangler-7664

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7664/npm-package-wrangler-7664

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-wrangler-7664 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-cloudflare-workers-bindings-extension-7664 -O ./cloudflare-workers-bindings-extension.0.0.0-v715c706fc.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v715c706fc.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-create-cloudflare-7664 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-cloudflare-kv-asset-handler-7664
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-miniflare-7664
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-cloudflare-pages-shared-7664
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-cloudflare-unenv-preset-7664
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-cloudflare-vitest-pool-workers-7664
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-cloudflare-workers-editor-shared-7664
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-cloudflare-workers-shared-7664
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12604169390/npm-package-cloudflare-workflows-shared-7664

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dario-piotrowicz dario-piotrowicz merged commit 5cc3bb1 into main Jan 7, 2025
29 of 30 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/7662/fullstack-names-fix branch January 7, 2025 09:23
@workers-devprod workers-devprod mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 BUG: C3 inconsistent fullstack framework names

3 participants