-
Notifications
You must be signed in to change notification settings - Fork 1k
add node:timers and node:net to unenv-preset #7853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ee8d022 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks, I had missed this one.
Looks like there might some formatting issue? Diff doesn't looks good for me.
Could you please add tests and bump the workerd peer dependency in package.json when the timers fix is released.
Thanks!
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-wrangler-7853You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7853/npm-package-wrangler-7853Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-wrangler-7853 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-cloudflare-workers-bindings-extension-7853 -O ./cloudflare-workers-bindings-extension.0.0.0-v06f5e7c24.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v06f5e7c24.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-create-cloudflare-7853 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-cloudflare-kv-asset-handler-7853miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-miniflare-7853@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-cloudflare-pages-shared-7853@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-cloudflare-unenv-preset-7853@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-cloudflare-vite-plugin-7853@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-cloudflare-vitest-pool-workers-7853@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-cloudflare-workers-editor-shared-7853@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-cloudflare-workers-shared-7853@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963384408/npm-package-cloudflare-workflows-shared-7853Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
28acd05 to
590b148
Compare
|
This is ready to land @vicb. Can you re-review? |
d9ee188 to
43b62b6
Compare
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🙂
e0375c0 to
017e5ba
Compare
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yagiz, I'll merge the 2 changesets
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anonrig I merged the changesets and changed to minor over patch.
Also added a basic timers/promises test
f1c1637 to
ee8d022
Compare
|
Thanks Pete! |
* add node:timers and node:util to unenv-preset * update unenv to 2.0.0-rc.1 * Update .changeset/popular-pigs-glow.md Co-authored-by: Dario Piotrowicz <[email protected]> * fixup! * fixup! format * fixup! update module tests --------- Co-authored-by: Victor Berchet <[email protected]> Co-authored-by: Dario Piotrowicz <[email protected]>
We currently implement node:timers and node:net in cloudflare workers. I've opened a similar PR to unenv as well: unjs/unenv#396