Skip to content

Conversation

@jkoe-cf
Copy link
Contributor

@jkoe-cf jkoe-cf commented Jan 31, 2025

What this PR solves / how to test
Allows user to configure lock configuration on an R2 bucket


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: changes covered by unit tests
  • Public documentation

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: f53b59d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jkoe-cf jkoe-cf force-pushed the jkoe/R2-2612 branch 4 times, most recently from 219cdf7 to f348a78 Compare February 3, 2025 19:51
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-wrangler-7977

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7977/npm-package-wrangler-7977

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-wrangler-7977 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-cloudflare-workers-bindings-extension-7977 -O ./cloudflare-workers-bindings-extension.0.0.0-v00f0bc929.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v00f0bc929.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-create-cloudflare-7977 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-cloudflare-kv-asset-handler-7977

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-miniflare-7977

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-cloudflare-pages-shared-7977

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-cloudflare-unenv-preset-7977

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-cloudflare-vite-plugin-7977

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-cloudflare-vitest-pool-workers-7977

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-cloudflare-workers-editor-shared-7977

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-cloudflare-workers-shared-7977

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549688131/npm-package-cloudflare-workflows-shared-7977

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.1
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@jkoe-cf jkoe-cf force-pushed the jkoe/R2-2612 branch 8 times, most recently from 8baf320 to 911107e Compare February 4, 2025 23:17
@jkoe-cf jkoe-cf marked this pull request as ready for review February 5, 2025 00:53
@jkoe-cf jkoe-cf requested a review from a team as a code owner February 5, 2025 00:53
@jkoe-cf jkoe-cf force-pushed the jkoe/R2-2612 branch 3 times, most recently from 743f60e to 3b406c5 Compare February 6, 2025 22:02
@emily-shen
Copy link
Contributor

would also be good to get some tests for invalid input 🧡

@jkoe-cf jkoe-cf force-pushed the jkoe/R2-2612 branch 6 times, most recently from c52c71b to bbc53c1 Compare February 14, 2025 20:01
@jkoe-cf jkoe-cf requested a review from emily-shen February 14, 2025 20:24
@jkoe-cf jkoe-cf force-pushed the jkoe/R2-2612 branch 2 times, most recently from 3205495 to 2f4dbe0 Compare February 20, 2025 01:18
Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, its best practice to refrain from squashing your commits/force pushing after a review, so the reviewer can see what has changed since 🧡
If you want to tidy up your commit history you can do that after approval, but also we squash merge to main in this repo anyway so it doesn't really matter a whole lot here 🧡

}

if (lockDays !== undefined) {
if (!isNaN(lockDays)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is not necessary, because if the input isn't a number yargs will have failed already when its passing the cli args

if (lockDays !== undefined) {
if (!isNaN(lockDays)) {
if (lockDays > 0) {
const conditionDaysValue = Number(lockDays) * 86400; // Convert days to seconds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - yargs will have set the type of lockDays as a number, so there's no need to cast this to a number again. typescript would have let you know if the type was wrong :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's something with the test setup vs. how wrangler works in practice but it looks like it still reaches there if the type is wrong so I might leave the NaN logic as-is if that's ok

`[Error: Days must be a number.]`

@jkoe-cf jkoe-cf force-pushed the jkoe/R2-2612 branch 2 times, most recently from 99db3e4 to ebaf008 Compare February 25, 2025 16:20
@emily-shen emily-shen merged commit 36ef9c6 into cloudflare:main Feb 26, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants