Skip to content

Conversation

@Ltadrian
Copy link
Contributor

@Ltadrian Ltadrian commented Mar 3, 2025

Fixes #[insert GH or internal issue link(s)].

  • Add mtls fields to hyperdrive command ca_certificate_uuid and mtls_certificate_uuid

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e test
  • Public documentation

@Ltadrian Ltadrian requested a review from a team as a code owner March 3, 2025 22:49
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2025

🦋 Changeset detected

Latest commit: 2b56c16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Ltadrian Ltadrian force-pushed the agracia/SQC-354-update-hyperdrive-commands branch from 3c92883 to 4085cfc Compare March 4, 2025 16:48
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 11, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-wrangler-8337

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8337/npm-package-wrangler-8337

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-wrangler-8337 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-workers-bindings-extension-8337 -O ./cloudflare-workers-bindings-extension.0.0.0-vcb715c6e6.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vcb715c6e6.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-create-cloudflare-8337 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-kv-asset-handler-8337

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-miniflare-8337

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-pages-shared-8337

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-unenv-preset-8337

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-vite-plugin-8337

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-vitest-pool-workers-8337

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-workers-editor-shared-8337

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-workers-shared-8337

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-workflows-shared-8337

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250310.0
workerd 1.20250310.0 1.20250310.0
workerd --version 1.20250310.0 2025-03-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@Ltadrian Ltadrian force-pushed the agracia/SQC-354-update-hyperdrive-commands branch from 4085cfc to f9c8535 Compare March 11, 2025 14:35
Copy link
Contributor

@ReppCodes ReppCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM.

`);
});

it("should handle updating a hyperdrive config's mtls configuration", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a few tests for possible failure scenarios (if any).

@Ltadrian Ltadrian force-pushed the agracia/SQC-354-update-hyperdrive-commands branch from f9c8535 to a259cef Compare March 11, 2025 15:49
@Ltadrian Ltadrian force-pushed the agracia/SQC-354-update-hyperdrive-commands branch from a259cef to 2b56c16 Compare March 13, 2025 14:58
@emily-shen emily-shen merged commit 1b2aa91 into cloudflare:main Mar 14, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 14, 2025
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Mar 14, 2025
@holopin-bot
Copy link

holopin-bot bot commented Mar 14, 2025

Congratulations @Ltadrian, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm88my77i20730cl7qwlubh7y

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants