-
Notifications
You must be signed in to change notification settings - Fork 1.1k
SQC-354 add mtls fields to hyperdrive #8337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQC-354 add mtls fields to hyperdrive #8337
Conversation
🦋 Changeset detectedLatest commit: 2b56c16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3c92883 to
4085cfc
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-wrangler-8337You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8337/npm-package-wrangler-8337Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-wrangler-8337 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-workers-bindings-extension-8337 -O ./cloudflare-workers-bindings-extension.0.0.0-vcb715c6e6.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vcb715c6e6.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-create-cloudflare-8337 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-kv-asset-handler-8337miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-miniflare-8337@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-pages-shared-8337@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-unenv-preset-8337@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-vite-plugin-8337@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-vitest-pool-workers-8337@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-workers-editor-shared-8337@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-workers-shared-8337@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13837741127/npm-package-cloudflare-workflows-shared-8337Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
4085cfc to
f9c8535
Compare
ReppCodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise LGTM.
| `); | ||
| }); | ||
|
|
||
| it("should handle updating a hyperdrive config's mtls configuration", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have a few tests for possible failure scenarios (if any).
f9c8535 to
a259cef
Compare
a259cef to
2b56c16
Compare
|
Congratulations @Ltadrian, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm88my77i20730cl7qwlubh7y This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Fixes #[insert GH or internal issue link(s)].
ca_certificate_uuidandmtls_certificate_uuid