Skip to content

Conversation

@emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Mar 6, 2025

Fixes DEVX-1724, 1725, 1726, 1702


@emily-shen emily-shen requested a review from a team March 6, 2025 10:32
@emily-shen emily-shen requested a review from a team as a code owner March 6, 2025 10:32
@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 90e8cbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen added the c3-e2e Run c3 e2e tests on a PR label Mar 6, 2025
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-wrangler-8372

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8372/npm-package-wrangler-8372

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-wrangler-8372 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-workers-bindings-extension-8372 -O ./cloudflare-workers-bindings-extension.0.0.0-vb66c1894a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vb66c1894a.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-create-cloudflare-8372 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-kv-asset-handler-8372

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-miniflare-8372

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-pages-shared-8372

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-unenv-preset-8372

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-vite-plugin-8372

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-vitest-pool-workers-8372

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-workers-editor-shared-8372

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-workers-shared-8372

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-workflows-shared-8372

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250224.0
workerd 1.20250224.0 1.20250224.0
workerd --version 1.20250224.0 2025-02-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen force-pushed the emily/graduate-gatsby branch from 4a99f47 to b316173 Compare March 6, 2025 15:43
@emily-shen emily-shen changed the title chore: graduate nuxt, gatsby, angular templates chore: graduate nuxt, gatsby, angular, vue templates Mar 6, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 6, 2025
b.identifier("modules"),
b.arrayExpression([b.stringLiteral("nitro-cloudflare-dev")]),
);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Nitro 2.11, if we could opt-in users to the new generated config experience, that would be really nice!.

For this, we need to inject: { nitro: { cloudflare: { deployConfig: true, nodeCompat: true } }.

User config will be still read and respected in generated config and we probably enable it soon when cloudflare CI can detect migration for vars.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks! (btw now you might want to remove nodejs_compat from wrangler in template it should be auto generated - having it is also harmless)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah whoops just realised I only added it for the Workers template. I presume we want it for both Workers and Pages?

Thanks for fixing the wrangler config issue in nuxt dev yesterday btw!

@emily-shen emily-shen merged commit 3536670 into main Mar 7, 2025
25 checks passed
@emily-shen emily-shen deleted the emily/graduate-gatsby branch March 7, 2025 11:32
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 7, 2025
@workers-devprod workers-devprod mentioned this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c3-e2e Run c3 e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants