-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: graduate nuxt, gatsby, angular, vue templates #8372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 90e8cbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-wrangler-8372You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8372/npm-package-wrangler-8372Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-wrangler-8372 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-workers-bindings-extension-8372 -O ./cloudflare-workers-bindings-extension.0.0.0-vb66c1894a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vb66c1894a.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-create-cloudflare-8372 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-kv-asset-handler-8372miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-miniflare-8372@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-pages-shared-8372@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-unenv-preset-8372@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-vite-plugin-8372@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-vitest-pool-workers-8372@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-workers-editor-shared-8372@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-workers-shared-8372@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13719059185/npm-package-cloudflare-workflows-shared-8372Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
4a99f47 to
b316173
Compare
| b.identifier("modules"), | ||
| b.arrayExpression([b.stringLiteral("nitro-cloudflare-dev")]), | ||
| ); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Nitro 2.11, if we could opt-in users to the new generated config experience, that would be really nice!.
For this, we need to inject: { nitro: { cloudflare: { deployConfig: true, nodeCompat: true } }.
User config will be still read and respected in generated config and we probably enable it soon when cloudflare CI can detect migration for vars.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks! (btw now you might want to remove nodejs_compat from wrangler in template it should be auto generated - having it is also harmless)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah whoops just realised I only added it for the Workers template. I presume we want it for both Workers and Pages?
Thanks for fixing the wrangler config issue in nuxt dev yesterday btw!
Fixes DEVX-1724, 1725, 1726, 1702