Skip to content

fix c3 tests #8491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2025
Merged

fix c3 tests #8491

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ada9416
add tab to types line
emily-shen Mar 14, 2025
93f3058
change line check
emily-shen Mar 14, 2025
4168041
allow both old and new type format
emily-shen Mar 14, 2025
46197bc
Fix new types snapshot
penalosa Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/create-cloudflare/e2e-tests/frameworks.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,9 +389,14 @@ const verifyBuildCfTypesScript = async (
expect(outputFileContentPostLines).not.toContain("// Generated by Wrangler");

// the file still contains the env interface
expect(outputFileContentPostLines).toContain(
`interface ${envInterfaceName} {`,
const hasEnvInterface = outputFileContentPostLines.some(
(line) =>
// old type gen - some frameworkte templates pin older versions of wrangler
line === `interface ${envInterfaceName} {` ||
// new after importable env change
line === `interface ${envInterfaceName} extends Cloudflare.Env {}`,
);
expect(hasEnvInterface).toBe(true);
};

const verifyBuildScript = async (
Expand Down
Loading