Skip to content

Conversation

@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Mar 27, 2025

Fixes DEVX-1707


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no test facing change
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Not Wrangler nor Vite plugin related
  • Public documentation
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: C3 is not backported

@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2025

🦋 Changeset detected

Latest commit: 3225150

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the c3-e2e Run c3 e2e tests on a PR label Mar 27, 2025
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-wrangler-8698

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8698/npm-package-wrangler-8698

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-wrangler-8698 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-cloudflare-workers-bindings-extension-8698 -O ./cloudflare-workers-bindings-extension.0.0.0-va423c5f57.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va423c5f57.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-create-cloudflare-8698 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-cloudflare-kv-asset-handler-8698

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-miniflare-8698

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-cloudflare-pages-shared-8698

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-cloudflare-unenv-preset-8698

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-cloudflare-vite-plugin-8698

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-cloudflare-vitest-pool-workers-8698

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-cloudflare-workers-editor-shared-8698

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-cloudflare-workers-shared-8698

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14282057934/npm-package-cloudflare-workflows-shared-8698

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250404.0
workerd 1.20250404.0 1.20250404.0
workerd --version 1.20250404.0 2025-04-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin
Copy link
Contributor Author

petebacondarwin commented Apr 4, 2025

  • I need to skip the prompt when there is only one option

@petebacondarwin petebacondarwin force-pushed the pbd/c3/remove-workers-assets-beta branch from b59ed26 to 3bd4c13 Compare April 4, 2025 15:29
@petebacondarwin petebacondarwin marked this pull request as ready for review April 4, 2025 15:31
@petebacondarwin petebacondarwin requested a review from a team April 4, 2025 15:31
@petebacondarwin petebacondarwin requested a review from a team as a code owner April 4, 2025 15:31
Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually tested as well :)

i think this hasn't been rebased since nextjs graduated, could you rebase and hide the next on pages template?

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 4, 2025
@emily-shen
Copy link
Contributor

emily-shen commented Apr 4, 2025

  • I need to skip the prompt when there is only one option

up to you, but maybe it would be helpful to still show the prompt so you know which platform you've ended up with?

@petebacondarwin
Copy link
Contributor Author

i think this hasn't been rebased since nextjs graduated, could you rebase and hide the next on pages template?

Hidden next-on-pages too

@petebacondarwin
Copy link
Contributor Author

  • I need to skip the prompt when there is only one option

up to you, but maybe it would be helpful to still show the prompt so you know which platform you've ended up with?

The prompt is shown but the question is skipped:

image

@emily-shen
Copy link
Contributor

emily-shen commented Apr 4, 2025

qwik has both options workers and pages, but if you try analog which only has pages:
Screenshot 2025-04-04 at 17 18 51

i guess this is the same behaviour its always had so it really doesn't have to be resolved here, just never really noticed it until i was trying a bunch of frameworks in a row.

@petebacondarwin
Copy link
Contributor Author

qwik has both options workers and pages, but if you try analog which only has pages. i guess this is the same behaviour its always had so it really doesn't have to be resolved here, just never really noticed it until i was trying a bunch of frameworks in a row.

Ah right. We should add Workers support after Dev Week and then this will resolve itself 😄

Thanks for the testing and reviewing!

@petebacondarwin petebacondarwin force-pushed the pbd/c3/remove-workers-assets-beta branch from b377ba6 to d37efb6 Compare April 5, 2025 07:09
@petebacondarwin petebacondarwin merged commit 1ba9e97 into main Apr 5, 2025
22 checks passed
@petebacondarwin petebacondarwin deleted the pbd/c3/remove-workers-assets-beta branch April 5, 2025 13:15
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 5, 2025
@workers-devprod workers-devprod mentioned this pull request Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c3-e2e Run c3 e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants