refactor(wrangler): add metafile flag, pass to build functions, adjus…

[ItsWendell]

Additionally adds a --metafile flag and adjusts tests and added it to all build flows.

fixes #4633

(first attempyt #7927)

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because:
• Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because: not affected
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s): Add --metafile flag to pages functions build and wrangler deploy cloudflare-docs#22349
  • Documentation not necessary because:
• Wrangler V3 Backport
  • TODO (before merge)
  • Wrangler PR:
  • Not necessary because: not a patch change

[changeset-bot]

🦋 Changeset detected

Latest commit: 37250ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Minor
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[emily-shen]

Hey, thanks for putting this PR up, sorry its been sitting a while - dev week has been a bit hectic :)

Couple of things:

• can you rebase on main? the original pr was from quite a while ago, and there's been some refactoring in the deploy command.
• can you add a changeset?

[ItsWendell]

@emily-shen I added a changeset, rebased, cleaned up and adjusted the PR to point to main. If there's any adjustments I can make let me know!

[github-actions]

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-wrangler-8716

Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-cloudflare-workers-bindings-extension-8716 -O ./cloudflare-workers-bindings-extension.0.0.0-v20eb42421.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v20eb42421.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-create-cloudflare-8716 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-cloudflare-kv-asset-handler-8716

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-miniflare-8716

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-cloudflare-pages-shared-8716

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-cloudflare-unenv-preset-8716

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-cloudflare-vite-plugin-8716

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-cloudflare-vitest-pool-workers-8716

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-cloudflare-workers-editor-shared-8716

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-cloudflare-workers-shared-8716

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14973160571/npm-package-cloudflare-workflows-shared-8716

Note that these links will no longer work once the GitHub Actions artifact expires.

[ItsWendell]

Here's something cool that we can explore potentially after this patch too, with an --analyze flag for example, if I link the latest version of this PR to a simple hono project and add the following script to my pacakge.json:

    "analyze": "wrangler deploy --dry-run --metafile=./meta.json && bunx esbuild-visualizer --metadata ./meta.json && xdg-open stats.html"

Using esbuild-visualiser since it runs locally and was easy to add to the command here, but there's alternatives like https://github.com/filipsobol/sonda too.

I get the following when I run pnpm run analyze:

[ItsWendell]

@emily-shen Thanks for the review, I've done the changes you requested and simplified the flag description.

[vicb]

@ItsWendell Thanks for the PR and sorry for the delay.

Could you please work on a doc PR (https://github.com/cloudflare/cloudflare-docs) or at least create an issue there.

Please mention me (@vicb) when you rebase the current PR and on the doc PR/issue to make sure I don't miss the notification.

[emily-shen]

lgtm pending some minor changes! let me know if you need a hand with docs, and thanks so much for the contribution 🧡

[holopin-bot]

Congratulations @ItsWendell, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmal7025c09130djsl1bsd50u

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

[DaniFoldi]

Many many thanks @ItsWendell for implementing this 🔥

[vicb]

Awesome feature, thanks to @ItsWendell and @emily-shen 🙏

[ItsWendell]

As a potential follow-up, it would be cool if wrangler had a built-in bundle analyzer.

wrangler analyze

Or something similar, are you open to discussing this and how it would fit within the repository? E.g. by using CLI-based output or potentially one of the few open source projects / dependencies that take an esbuild metafile and shows a GUI web interface for it, as a optional dependency, or something self built?

@vicb @emily-shen

[vicb]

@ItsWendell feel free to start a discussion (ping me there so that I get notified).

IMO we don't want to add this to the workers-sdk because that it something we would have to maintain. There is also https://esbuild.github.io/analyze/ already and improving that is probably is better idea rather than duplicating.

But again if you start a discussion, we can discuss internally to see if others have a different opinion.