Skip to content

Conversation

@LuisDuarte1
Copy link
Contributor

This uses some @ts-expect-errors since these are not in workers-types, yet.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: new feature

@LuisDuarte1 LuisDuarte1 requested review from a team as code owners April 3, 2025 16:49
@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: e1e0354

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
miniflare Patch
@cloudflare/workflows-shared Patch
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuisDuarte1 LuisDuarte1 force-pushed the lduarte/wait-for-event-local-dev branch 3 times, most recently from a4e48d4 to a317a5a Compare April 4, 2025 14:03
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-wrangler-8775

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8775/npm-package-wrangler-8775

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-wrangler-8775 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-cloudflare-workers-bindings-extension-8775 -O ./cloudflare-workers-bindings-extension.0.0.0-v8ee9f92d6.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8ee9f92d6.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-create-cloudflare-8775 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-cloudflare-kv-asset-handler-8775

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-miniflare-8775

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-cloudflare-pages-shared-8775

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-cloudflare-unenv-preset-8775

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-cloudflare-vite-plugin-8775

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-cloudflare-vitest-pool-workers-8775

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-cloudflare-workers-editor-shared-8775

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-cloudflare-workers-shared-8775

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14305979562/npm-package-cloudflare-workflows-shared-8775

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250404.0
workerd 1.20250405.0 1.20250405.0
workerd --version 1.20250405.0 2025-04-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@LuisDuarte1 LuisDuarte1 added the e2e Run wrangler + vite-plugin e2e tests on a PR label Apr 4, 2025
dependabot bot and others added 2 commits April 5, 2025 13:39
Bumps the workerd-and-workers-types group with 2 updates: [@cloudflare/workers-types](https://github.com/cloudflare/workerd) and [workerd](https://github.com/cloudflare/workerd).


Updates `@cloudflare/workers-types` from 4.20250404.0 to 4.20250405.0
- [Release notes](https://github.com/cloudflare/workerd/releases)
- [Changelog](https://github.com/cloudflare/workerd/blob/main/Dockerfile.release)
- [Commits](https://github.com/cloudflare/workerd/commits)

Updates `workerd` from 1.20250404.0 to 1.20250405.0
- [Release notes](https://github.com/cloudflare/workerd/releases)
- [Changelog](https://github.com/cloudflare/workerd/blob/main/Dockerfile.release)
- [Commits](cloudflare/workerd@v1.20250404.0...v1.20250405.0)

---
updated-dependencies:
- dependency-name: "@cloudflare/workers-types"
  dependency-version: 4.20250405.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: workerd-and-workers-types
- dependency-name: workerd
  dependency-version: 1.20250405.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: workerd-and-workers-types
...

Signed-off-by: dependabot[bot] <[email protected]>
The following dependency versions have been updated:

| Dependency                | From          | To            |
| ------------------------- | ------------- | ------------- |
| workerd                   | 1.20250404.0  | 1.20250405.0  |
| @cloudflare/workers-types | ^4.20250404.0 | ^4.20250405.0 |
LuisDuarte1 and others added 3 commits April 5, 2025 17:28
This uses some @ts-expect-errors since these are not in workers-types,
yet.
This uses some @ts-expect-errors since these are not in workers-types,
yet.
@petebacondarwin petebacondarwin force-pushed the lduarte/wait-for-event-local-dev branch from a317a5a to 88514d0 Compare April 5, 2025 16:33
@petebacondarwin petebacondarwin requested a review from a team April 5, 2025 16:33
@workers-devprod workers-devprod added the c3-e2e Run c3 e2e tests on a PR label Apr 5, 2025
@petebacondarwin
Copy link
Contributor

Rebased on top of the latest workerd and workers-types.
Nearly fixed but there a problem in workflows-shared/src/engine.ts where we need to pass a WorkflowStep object to the target.run() function. Previously this was just a Context instance but that is no longer valid.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 7, 2025
@petebacondarwin petebacondarwin merged commit ec7e621 into main Apr 7, 2025
28 of 31 checks passed
@petebacondarwin petebacondarwin deleted the lduarte/wait-for-event-local-dev branch April 7, 2025 11:25
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 7, 2025
@workers-devprod workers-devprod mentioned this pull request Apr 7, 2025
@edmundhung edmundhung restored the lduarte/wait-for-event-local-dev branch April 8, 2025 20:39
edmundhung pushed a commit that referenced this pull request Apr 8, 2025
@edmundhung edmundhung deleted the lduarte/wait-for-event-local-dev branch April 8, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c3-e2e Run c3 e2e tests on a PR e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants