Add support for Vitest 3.1.x #8804

boimw · 2025-04-07T08:26:25Z

This MR adds support for Vitest 3.1.x and it fixes peer dependency with vitest, @vitest/coverage-istanbul and similar packages.

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because: dependency update
Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s): update supported vitest versions cloudflare-docs#21700
- Documentation not necessary because:
Wrangler V3 Backport
- TODO (before merge)
- Wrangler PR:
- Not necessary because: not a Wrangler change.

changeset-bot · 2025-04-07T08:26:28Z

🦋 Changeset detected

Latest commit: 7469234

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudflare/vitest-pool-workers	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

boimw · 2025-04-07T08:29:20Z

Hey @petebacondarwin 👋 could you please review this dependency update? 🙇‍♂️

petebacondarwin · 2025-04-07T08:44:39Z

Running the tests but this PR will need a bit more: a changeset and possible updates to the version of Vitest we are using in our testing and fixtures...

github-actions · 2025-04-07T08:49:39Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-wrangler-8804

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8804/npm-package-wrangler-8804

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-wrangler-8804 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-cloudflare-workers-bindings-extension-8804 -O ./cloudflare-workers-bindings-extension.0.0.0-v3b6328a53.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v3b6328a53.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-create-cloudflare-8804 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-cloudflare-kv-asset-handler-8804

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-miniflare-8804

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-cloudflare-pages-shared-8804

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-cloudflare-unenv-preset-8804

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-cloudflare-vite-plugin-8804

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-cloudflare-vitest-pool-workers-8804

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-cloudflare-workers-editor-shared-8804

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-cloudflare-workers-shared-8804

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14359986022/npm-package-cloudflare-workflows-shared-8804

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	4.20250408.0
`workerd`	1.20250408.0	1.20250408.0
`workerd --version`	1.20250408.0	2025-04-08

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

boimw · 2025-04-08T10:10:02Z

Running the tests but this PR will need a bit more: a changeset and possible updates to the version of Vitest we are using in our testing and fixtures...

Thanks @petebacondarwin

I've added changeset and updated vitest versions inside pnpm-workspace.yaml. Could you please take another look?

penalosa

This looks generally good, but shouldn't update esbuild

penalosa · 2025-04-08T10:12:58Z

pnpm-workspace.yaml

+  vitest: "~3.1.1"
  vite: "^5.4.14"
  "ws": "8.18.0"
-  esbuild: "0.24.2"


This PR shouldn't be updating esbuild—it should be limited to Vitest

Gotcha, I've updated esbuild due to vulnerability concern.

Anyhow, I've dropped it for now.

boimw · 2025-04-08T10:51:45Z

Updated, thanks for the support @petebacondarwin

Back to you 🏓

petebacondarwin · 2025-04-08T14:03:19Z

Looks like Vitest 3.1 is formatting snapshots slightly differently?

https://github.com/cloudflare/workers-sdk/actions/runs/14331654155/job/40169757071?pr=8804#step:5:1161

I'll update and push a commit.

boimw · 2025-04-09T14:39:59Z

@petebacondarwin I just solved the conflicts, back to you 🏓

alsuren

I assume D1 has been tagged for a code owner review because of packages/wrangler/src/tests/d1/insights.test.ts , so I'm happy to approve that bit to unblock you (assuming that tests still pass), but please wait for someone on the wrangler team to approve the rest before merging.

github-actions · 2025-04-14T07:04:21Z

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-wrangler-8804

Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-cloudflare-workers-bindings-extension-8804 -O ./cloudflare-workers-bindings-extension.0.0.0-v7342524d4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v7342524d4.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-create-cloudflare-8804 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-cloudflare-kv-asset-handler-8804

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-miniflare-8804

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-cloudflare-pages-shared-8804

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-cloudflare-unenv-preset-8804

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-cloudflare-vite-plugin-8804

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-cloudflare-vitest-pool-workers-8804

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-cloudflare-workers-editor-shared-8804

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-cloudflare-workers-shared-8804

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14439012554/npm-package-cloudflare-workflows-shared-8804

Note that these links will no longer work once the GitHub Actions artifact expires.

requested change has been made

holopin-bot · 2025-04-15T22:15:31Z

Congratulations @boimw, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm9j29xnm00470cjxsigjzyva

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

boimw added 2 commits April 7, 2025 10:23

Adds vitest 3.1.x support

9d7985e

Merge branch 'cloudflare:main' into main

8ec41fb

boimw requested a review from a team as a code owner April 7, 2025 08:26

workers-devprod added this to workers-sdk Apr 7, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Apr 7, 2025

edmundhung added post-devweek vitest Relating to the Workers Vitest integration labels Apr 7, 2025

workers-devprod mentioned this pull request Apr 7, 2025

Run CI on behalf of #8804 #8826

Closed

boimw added 4 commits April 8, 2025 11:36

Merge branch 'cloudflare:main' into main

5ab82bd

Bump up esbuild to 0.25.1 to address vulnerability concern

8dfa8e7

Adds missing changeset

1c3a070

Bump up local vitest versions

f884c63

penalosa previously requested changes Apr 8, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to In Review in workers-sdk Apr 8, 2025

Rollback eslint update

ea3cb56

petebacondarwin self-assigned this Apr 8, 2025

fixup snapshot

a2c478a

petebacondarwin requested a review from a team as a code owner April 8, 2025 14:27

Merge branch 'main' into main

d230ab9

Merge branch 'main' into main

cfdb058

alsuren approved these changes Apr 11, 2025

View reviewed changes

Merge branch 'main' into main

7469234

boimw requested a review from penalosa April 14, 2025 06:33

emily-shen added e2e Run wrangler + vite-plugin e2e tests on a PR c3-e2e Run c3 e2e tests on a PR labels Apr 15, 2025

workers-devprod mentioned this pull request Apr 15, 2025

Run CI on behalf of #8804 #8944

Closed

emily-shen approved these changes Apr 15, 2025

View reviewed changes

emily-shen merged commit 8a0cf56 into cloudflare:main Apr 15, 2025
81 of 102 checks passed

github-project-automation bot moved this from In Review to Done in workers-sdk Apr 15, 2025

workers-devprod mentioned this pull request Apr 15, 2025

Version Packages #8965

Merged

workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Apr 15, 2025

lrapoport-cf mentioned this pull request Apr 17, 2025

fix changesets #8991

Merged

12 tasks

cjlawson02 mentioned this pull request Apr 26, 2025

[Workers] Update vitest-pool-workers docs to newer vitest version cloudflare/cloudflare-docs#21998

Closed

1 task

Add support for Vitest 3.1.x #8804

Add support for Vitest 3.1.x #8804

Uh oh!

Conversation

boimw commented Apr 7, 2025 • edited by emily-shen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

boimw commented Apr 7, 2025

Uh oh!

petebacondarwin commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boimw commented Apr 8, 2025

Uh oh!

penalosa left a comment

Choose a reason for hiding this comment

Uh oh!

penalosa Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

boimw Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boimw commented Apr 8, 2025

Uh oh!

petebacondarwin commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boimw commented Apr 9, 2025

Uh oh!

alsuren left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

Uh oh!

holopin-bot bot commented Apr 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

boimw commented Apr 7, 2025 •

edited by emily-shen

Loading

changeset-bot bot commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

boimw Apr 8, 2025 •

edited

Loading

petebacondarwin commented Apr 8, 2025 •

edited

Loading