Skip to content

rename c3 options #8874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2025
Merged

rename c3 options #8874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e061fe
rename options
emily-shen Apr 10, 2025
618ccde
changeset
emily-shen Apr 10, 2025
4e8aa03
fixup
emily-shen Apr 10, 2025
d18ad9f
fixup :(
emily-shen Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/breezy-cats-trade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"create-cloudflare": patch
---

rename hello world templates with assets

Worker + Assets -> SSR / full-stack app
Assets only -> Static site
8 changes: 4 additions & 4 deletions packages/create-cloudflare/e2e-tests/cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ describe.skipIf(experimental || frameworkToTest || isQuarantineMode())(

expect(project.path).toExist();
expect(output).toContain(`category Hello World example`);
expect(output).toContain(`type Worker + Assets`);
expect(output).toContain(`type SSR / full-stack app`);
expect(output).toContain(`lang TypeScript`);
expect(output).toContain(`no deploy`);
},
Expand Down Expand Up @@ -177,7 +177,7 @@ describe.skipIf(experimental || frameworkToTest || isQuarantineMode())(
);

expect(project.path).toExist();
expect(output).toContain(`type Worker + Assets`);
expect(output).toContain(`type SSR / full-stack app`);
expect(output).toContain(`lang TypeScript`);
expect(output).toContain(`no deploy`);
} finally {
Expand Down Expand Up @@ -548,9 +548,9 @@ describe.skipIf(frameworkToTest || isQuarantineMode())("help text", () => {
hello-world
For processing requests, transforming responses, or API endpoints
hello-world-assets-only
For static sites (including SPAs) or when using your own backend
For static sites or when using your own backend. Uses Workers Static Assets.
hello-world-with-assets
For static sites with an API or server-side rendering (SSR)
For sites with a backend API, or server-side rendering (SSR). Uses Static Assets with a Worker.
hello-world-durable-object
For multiplayer apps using WebSockets, or when you need synchronization
hello-world-durable-object-with-assets
Expand Down
4 changes: 2 additions & 2 deletions packages/create-cloudflare/templates/hello-world-assets-only/c3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ const config: TemplateConfig = {
configVersion: 1,
id: "hello-world-assets-only",
path: "templates/hello-world-assets-only",
displayName: "Assets only",
displayName: "Static site",
description:
"For static sites (including SPAs) or when using your own backend",
"For static sites or when using your own backend. Uses Workers Static Assets.",
platform: "workers",
copyFiles: {
path: "./templates",
Expand Down
5 changes: 3 additions & 2 deletions packages/create-cloudflare/templates/hello-world-with-assets/c3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ const config: TemplateConfig = {
configVersion: 1,
id: "hello-world-with-assets",
path: "templates/hello-world-with-assets",
displayName: "Worker + Assets",
description: "For static sites with an API or server-side rendering (SSR)",
displayName: "SSR / full-stack app",
description:
"For sites with a backend API, or server-side rendering (SSR). Uses Static Assets with a Worker.",
platform: "workers",
copyFiles: {
variants: {
Expand Down
Loading