Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Apr 28, 2025

Fetching from the same worker (more generally a worker in the same zone) fails for deployed workers without this flag. Adding this flag makes sense when there is no origin server - probably we should consider adding it for all frameworks?

(note that same worker fetch works with wrangler dev)

Our current workaround is to create a service binding in wrangler.jsonc - this PR will allow to simplify the config.

Ref:

/cc @conico974 @james-elicx

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: covered by existing tests
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: not affected
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: I'll updatre the OpenNext docs later
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: does not apply there

@vicb vicb requested a review from a team April 28, 2025 12:46
@vicb vicb requested a review from a team as a code owner April 28, 2025 12:46
@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2025

🦋 Changeset detected

Latest commit: d3e3aa5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Apr 28, 2025
@workers-devprod workers-devprod added the c3-e2e Run c3 e2e tests on a PR label Apr 28, 2025
@github-actions
Copy link
Contributor

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-wrangler-9087
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-cloudflare-workers-bindings-extension-9087 -O ./cloudflare-workers-bindings-extension.0.0.0-v8f012f3f1.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8f012f3f1.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-create-cloudflare-9087 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-cloudflare-kv-asset-handler-9087

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-miniflare-9087

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-cloudflare-pages-shared-9087

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-cloudflare-unenv-preset-9087

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-cloudflare-vite-plugin-9087

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-cloudflare-vitest-pool-workers-9087

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-cloudflare-workers-editor-shared-9087

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-cloudflare-workers-shared-9087

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14708149812/npm-package-cloudflare-workflows-shared-9087

Note that these links will no longer work once the GitHub Actions artifact expires.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 29, 2025
@vicb vicb merged commit 79593e6 into main Apr 29, 2025
29 of 36 checks passed
@vicb vicb deleted the vicb/public-fetch branch April 29, 2025 09:03
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c3-e2e Run c3 e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants