Skip to content

Conversation

@avenceslau
Copy link
Contributor

@avenceslau avenceslau commented May 2, 2025

Fixes #[insert GH or internal issue link(s)].

Describe your change...
Unhide wrangler workflow delete command

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: not a patch change, just unhiding a command that already exists

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: 397eb68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk May 2, 2025
@avenceslau avenceslau added the e2e Run wrangler + vite-plugin e2e tests on a PR label May 2, 2025
@avenceslau avenceslau self-assigned this May 2, 2025
@avenceslau avenceslau marked this pull request as ready for review May 5, 2025 10:58
@avenceslau avenceslau requested a review from a team as a code owner May 5, 2025 10:58
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-wrangler-9122
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-cloudflare-workers-bindings-extension-9122 -O ./cloudflare-workers-bindings-extension.0.0.0-vde9dd2134.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vde9dd2134.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-create-cloudflare-9122 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-cloudflare-kv-asset-handler-9122

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-miniflare-9122

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-cloudflare-pages-shared-9122

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-cloudflare-unenv-preset-9122

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-cloudflare-vite-plugin-9122

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-cloudflare-vitest-pool-workers-9122

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-cloudflare-workers-editor-shared-9122

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-cloudflare-workers-shared-9122

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14863147973/npm-package-cloudflare-workflows-shared-9122

Note that these links will no longer work once the GitHub Actions artifact expires.

Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are no relevant e2e tests, but i don't see much point adding them either to essentially test the api works. so i have tested this manually and confirms it works fine.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk May 7, 2025
@emily-shen emily-shen merged commit f17ee08 into main May 8, 2025
18 checks passed
@emily-shen emily-shen deleted the wrangler-delete-workflow branch May 8, 2025 09:19
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk May 8, 2025
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label May 8, 2025
@holopin-bot
Copy link

holopin-bot bot commented May 8, 2025

Congratulations @avenceslau, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmaf5p9xp10880dju3voygdkw

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@workers-devprod workers-devprod mentioned this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants