fix: setting triggers.crons:[] in Wrangler config should delete deployed cron schedules #9266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a27875f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running |
Contributor
|
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-wrangler-9266Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-cloudflare-workers-bindings-extension-9266 -O ./cloudflare-workers-bindings-extension.0.0.0-vf635504a4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf635504a4.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-create-cloudflare-9266 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-cloudflare-kv-asset-handler-9266
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-miniflare-9266
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-cloudflare-pages-shared-9266
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-cloudflare-unenv-preset-9266
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-cloudflare-vite-plugin-9266
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-cloudflare-vitest-pool-workers-9266
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-cloudflare-workers-editor-shared-9266
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-cloudflare-workers-shared-9266
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15071947758/npm-package-cloudflare-workflows-shared-9266Note that these links will no longer work once the GitHub Actions artifact expires. |
petebacondarwin
added a commit
to petebacondarwin/cloudflare-docs
that referenced
this pull request
May 15, 2025
Merged
1 task
vicb
reviewed
May 15, 2025
petebacondarwin
force-pushed
the
pbd/wrangler/deletable-crons
branch
2 times, most recently
from
0e860ce to
c9b440c
Compare
petebacondarwin
force-pushed
the
pbd/wrangler/deletable-crons
branch
3 times, most recently
from
8d25ded to
14e67b4
Compare
Previously there were occasionally flakes where the module appeared to be unmocked when it was still supposed to be mocked.
…yed cron schedules
petebacondarwin
force-pushed
the
pbd/wrangler/deletable-crons
branch
from
14e67b4 to
a27875f
Compare
Merged
petebacondarwin
added a commit
that referenced
this pull request
May 19, 2025
…g should delete deployed cron schedules (#9267) * test: tighten up metrics module mocking Previously there were occasionally flakes where the module appeared to be unmocked when it was still supposed to be mocked. * fix: setting triggers.crons:[] in Wrangler config should delete deployed cron schedules --------- Co-authored-by: Peter Bacon Darwin <[email protected]>
petebacondarwin
added a commit
to cloudflare/cloudflare-docs
that referenced
this pull request
May 28, 2025
sdnts
pushed a commit
to sdnts/cloudflare-docs
that referenced
this pull request
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9180
Previously if the array was empty it would just not touch the deployed schedules.
Providing either
triggers: { crons: undefined }or notriggersproperty in your Wrangler configuration will continue to leave the deployed schedules untouched.